To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=106389 Issue #|106389 Summary|package: dubious && || in ZipPackageFolder.cxx Component|xml Version|DEV300m63 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|mav Reported by|cmc
------- Additional comments from [email protected] Wed Oct 28 15:36:49 +0000 2009 ------- i.e. we have... if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || ( pStream->IsPackageMember() && !bToBeEncrypted && ( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed ) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed ) ) ) ) which is parsed as if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || (( pStream->IsPackageMember() && !bToBeEncrypted && ( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed )) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed ) ) ) ) which is a little suspicious, I suspect it might have been intended to be if ( !bUseNonSeekableAccess && ( bRawStream || bTransportOwnEncrStreamAsRaw || ( pStream->IsPackageMember() && !bToBeEncrypted && (( pStream->aEntry.nMethod == DEFLATED && bToBeCompressed ) || ( pStream->aEntry.nMethod == STORED && !bToBeCompressed )) ) ) ) patch 1 keeps our current logic and silences warning, patch 2 changes the logic to what might have been intended --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
