To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=91504
------- Additional comments from maju...@openoffice.org Thu Oct 29 06:33:31 +0000 2009 ------- hi mst, Thanks very much to point out the question about SetValues(rPaM) in my patch. You are right that the rPaM became something invalid after Move operation(let me just call it misorder with start/end nContent index,but the start/end nNode index is still correct in rPaM) The call SetValues(rPaM) is used to update the Range in pUndo by rPaM in time( it should be called after inserting delete redline mainly because it changes the order of Nodes under hidden redlining mode ) The pRedlPaM is used in the AppendRedline(...REDLINE_DELETE...) which represents the range of delete redline, and then used in the AppendRedline(...REDLINE_INSERT...). But before AppendRedline(...REDLINE_INSERT...) pRedPaM was adjusted a little so it can represents the range of insert redline: But it only adjust the pPoint to the start of the range of insert redline(that is to say,its pMark is still at the start of range of delete redline). We should adjust its pMark member to be at the end of the range of insert redline,it's really one node offset!(i think delete redline is just followed insert redline) Really, i do think the redlining code is too complicated and there are conflict between undo and redlining...:( so in this patch: - moving the SetValues much lines down and use pRedlPam as you have suggested. Please check and point out if anything wrong or missed, thank you very much. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@sw.openoffice.org For additional commands, e-mail: issues-h...@sw.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
