To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=106384


User sb changed the following:

                What    |Old value                 |New value
================================================================================
                      CC|''                        |'er'
--------------------------------------------------------------------------------
                  Status|NEW                       |RESOLVED
--------------------------------------------------------------------------------
              Resolution|                          |FIXED
--------------------------------------------------------------------------------




------- Additional comments from [email protected] Thu Oct 29 14:52:43 +0000 
2009 -------
@cmc:  Patch looks good (taking the liberty to trivially turn the unions in
math.hxx into anonymous ones; anonymizing the one in math.cxx would appear to
trigger an error in GCC 4.2.3 complaining about unused variables, however).  Two
things to note:

1  With a naive compiler the modified setInf/setNan (math.hxx) might produce
worse code than before.  I assume those functions are not called often enough to
actually make us worry about that, but put Eike on cc nonetheless.

2  rtl_bootstrap_set (bootstrap.cxx) is probably called infrequently enough so
that I see no problem with the additional acquire/release of name/value. 
However, I guess the same warning is lurking in rtl::OUString::unacquired()
(ustring.hxx), where it would be hard to work around.

In any event, applied as
<http://hg.services.openoffice.org/cws/sb116/rev/6428cee2701a>.

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to