To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109791
------- Additional comments from [email protected] Wed Mar 3 21:39:17 +0000 2010 ------- > 1 libs.mk CPPUNITLIB: For one, shouldn't the check for SYSTEM_CPPUNIT come > before the check for WN (so that WNT could, at least in principle, also use SYSTEM_CPPUNIT)? no system-* will probably work on windows, nor would it make sense, so I wouldn't bother > For another, the "+=" in "CPPUNITLIB += $(CPPUNIT_LIBS)" is probably a typo. Yes. > (And for a third, wouldn't it be better to replace CPPUNITLIB with > CPPUNIT_LIBS everywhere and set it in libs.mk only if not SYSTEM_CPPUNIT?) Wanted to do it minimal-invasive, but we can do, yes. > 2 What looks odd is that only sal/cppunittester/makefile.mk mentions > CPPUNIT_CFLAGS, not the other makefiles that reference cppunit. I only noticed that one, will grep for the rest. they are for example? > (And again, wouldn't it be better if the CFLAGS+=CPPUNIT_CFLAGS > would be unconditional, and CPPUNIT_CFLAGS were set empty for the > non-SYSTEM_CPPUNIT case in some solenv/inc/*.mk?) I don't think so, libs != includes, and we don't do that for any other system-* either --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
