To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=109921 Issue #|109921 Summary|sw: meaningless tests against NULL Component|Word processor Version|DEV300m73 Platform|All URL| OS/Version|Linux Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ama Reported by|cmc
------- Additional comments from [email protected] Mon Mar 8 12:05:08 +0000 2010 ------- in sw/source/core/frmedt/feshview.cxx we first check if (pTmpObj)... ... if (pTmpObj) else foo Seeing as pTmpObj is not null, and is not modified afterwards, the foo branch can never be executed so patch to remove it attached. Similarly in sw/source/ui/uno/unotxvw.cxx we have... SwWrtShell* pOldSh = &m_pView->GetWrtShell(); if (pOldSh) foo Its not possible to pOldSh to not be NULL, so the if doesn't make any real sense. Patch also cleans that up. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
