To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112761
User sb changed the following:
What |Old value |New value
================================================================================
CC|'' |'is'
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Tue Jun 29 08:51:52 +0000
2010 -------
Ah, right, --disable-epm (we already discussed that back in January,
<http://porting.openoffice.org/servlets/ReadMsg?list=dev&msgNo=17347>).
So, if I understand correctly, the situation is as follows:
Before DEV300_m77, empty/unset PKGFORMAT caused instsetoo_native/util to call
make_installer.pl without -format switch.
Since DEV300_m77, instsetoo_native/util implicitly (but erroneously) assumes
that PKGFORMAT is non-empty, and always calls make_installer.pl with -format
switch.
However, make_installer.pl called without -format switch is the same as "-format
native" (see
if ( ! $installer::globals::packageformat ) {
$installer::globals::packageformat = "native"; }
in sub setglobalvariables in solenv/bin/modules/installer/parameter.pm).
So, instead of re-complicating things in instsetoo_native/util/makefile.mk,
would it not be better to change configure.in so that it sets PKGFORMAT=native
when --disable-epm? (A quick check of building instsetoo_native/util with
PKGFORMAT=native fails for me with "dpkg-deb: package name has characters that
aren't lowercase alphanums or `-+.'" when it calls epm, but it is unclear to me
whether that is due to my setup or a real problem.)
Any other places apart from instsetoo_native/util/makefile.mk that mention
PKGFORMAT would not be affected by such a change, it appears: start_build_server
in solenv/bin/modules/packager/work.pm reads PKGFORMAT and does something based
on that, but is probably only relevant for the Hamburg build system?; and
sysui/desktop/freedesktop/makefile.mk, sysui/desktop/mandriva/makefile.mk,
sysui/desktop/tg_rpm.mk, sysui/desktop/debian/makefile.mk,
sysui/desktop/suse/makefile.mk, sysui/desktop/util/makefile.mk,
sysui/desktop/redhat/makefile.mk, and setup_native/scripts/makefile.mk only
check whether PKGFORMAT contains "rpm" resp. "deb".
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
