To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=113722
User iha changed the following:
What |Old value |New value
================================================================================
Status|UNCONFIRMED |RESOLVED
--------------------------------------------------------------------------------
Resolution| |FIXED
--------------------------------------------------------------------------------
Summary|cppuhelper: New a new char|cppuhelper: OSingleFactory
|t object or load a documen|Helper::createInstanceWith
|t with chart, it shows obv|ArgumentsAndContext may le
|ious memory leak because o|ak if XInitialization is n
|f ChartModel object leaks |ot supported
--------------------------------------------------------------------------------
Target milestone|--- |OOo 3.4
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Thu Aug 19 07:20:48 +0000
2010 -------
Thanks zhangjfibm for pointing to that problem! The patch works.
However I would suggest an additional fix. To avoid the unnecessary duplicate
construction of the chart I will implement the XInitialization interface at the
ChartModel. Then this leak of course does not occur anymore for the chart, but
as the potential leak within
SingleFactoryHelper::createInstanceWithArgumentsAndContext can affect arbitrary
objects (not only the chart) I keep the code that cleans up the created objects
before throwing out.
@zhangjfibm, when changing code please avoid to introduce new tabs - use spaces
instead. Also it is good style to use the same coding style that is used in the
edited file already. For example if brackets are symmetric, do not introduce the
asymmetric form.
Thanks!
Fixed in CWS chart49:
http://hg.services.openoffice.org/cws/chart49/rev/d5ef7bc5ed01
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
