To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114412 Issue #|114412 Summary|sw: dubious delete in SwCalc::Str2Double Component|Word processor Version|DEV300m87 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|PATCH Priority|P3 Subcomponent|code Assigned to|ama Reported by|dtardon
------- Additional comments from [email protected] Wed Sep 8 13:25:12 +0000 2010 ------- There is the following code in BOOL SwCalc::Str2Double( const String& rCommand, xub_StrLen& rCommandPos, double& rVal, const LocaleDataWrapper* const pLclData ) : if( !pLclData && pLclD != &SvtSysLocale.GetLocaleData() ) delete (LocaleDataWrapper*)pLclD; . The condition is always false because pLclData is assigned from &SvtSysLocale::GetLocaleData() if it's 0. I've removed it and refactored the remaining code a bit to get rid of duplicate code. The patch is only applicable if the patch in #i114409# is also applied. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
