To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=114958 Issue #|114958 Summary|[vcl] provide mechanism to assert that solar mutex is |locked Component|gsl Version|DEV300m89 Platform|All URL| OS/Version|All Status|NEW Status whiteboard| Keywords| Resolution| Issue type|DEFECT Priority|P3 Subcomponent|code Assigned to|pl Reported by|mst
------- Additional comments from m...@openoffice.org Wed Oct 6 12:52:12 +0000 2010 ------- so, i want to have the ability to assert that the solar mutex is locked in certain locations in the code; could make debugging thread issues a bit easier. last year i hacked up something crude (with the help of pl) that adds a method Application::IsSolarMutexLocked. but now i've found out that there is already a mechanism for this. it is in tools/debug.hxx and called DBG_TESTSOLARMUTEX: http://svn.services.openoffice.org/opengrok/xref/DEV300_m89/tools/inc/tools/debug.hxx#681 the implementation is in VCL, and hooked up in dbggui.cxx: http://svn.services.openoffice.org/opengrok/xref/DEV300_m89/vcl/os2/source/app/salinst.cxx#303 http://svn.services.openoffice.org/opengrok/xref/DEV300_m89/vcl/source/app/dbggui.cxx#1967 the problem is that it is only implemented for WIN and OS2, and the OS2 implementation seems to be inactive. my attempt to implement this for X11 ran into trouble because apparently unx/source/app/salinst.cxx is not linked into libvcl, but into a plugin, but dbggui.cxx is in libvcl, so libvcl doesn't link. since i'm not sure which way to proceed is best here, i thought why not create an issue and let somebody who knows the byzantine makefiles in vcl deal with this :) i'll attach patches for the 2 attempts; i think i'd prefer if VCL does not export a function IsSolarMutexLocked (since that could be abused) but provides some way to do an ASSERT. of course, this should be added for all platforms. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@gsl.openoffice.org For additional commands, e-mail: issues-h...@gsl.openoffice.org --------------------------------------------------------------------- To unsubscribe, e-mail: allbugs-unsubscr...@openoffice.org For additional commands, e-mail: allbugs-h...@openoffice.org
