To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=84159
User mst changed the following:
What |Old value |New value
================================================================================
CC|'cornouws,gang65,mux2005,p|'cl,cornouws,gang65,mst,mu
|itonyak,tjfrazier' |x2005,pitonyak,tjfrazier'
--------------------------------------------------------------------------------
------- Additional comments from [email protected] Wed Oct 13 15:57:56 +0000
2010 -------
@Bartosz:
the fix looks good, except for the bit where the size of the array is
stored into a stream.
according to the discussion on [email protected], it should not be a
problem to simply change the stream format.
because this is a serialization we should use fixed size integer types.
size_t is not fixed size, it can be 32 or 64 bit depending on C++
implementation.
i think the following should work:
in SfxItemPool::Store() ~line230 initialize the count like this:
sal_uInt32 nCount = ::std::min<size_t>( (*pArr)->size(), SAL_MAX_UINT32 );
this way we never write more than 2^32 items.
should be enough even for Andrew :)
in SfxItemPool::Load() ~line635 just change type of count to sal_uInt32.
and adapt the signature of readTheItems()
---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
