To comment on the following update, log in, then open the issue:
http://www.openoffice.org/issues/show_bug.cgi?id=112395





------- Additional comments from [email protected] Fri Nov 19 13:50:07 +0000 
2010 -------
indeed, we overlooked an implementation detail of the old stack:

        AE Top() const {\
                AE pRet = 0;\
                if( SvPtrarr::Count() )\
                        pRet = GetObject( SvPtrarr::Count()-1 ); \
                return pRet;\
        }\

if the stack is empty, the Top and Pop methods will return a null pointer.
on an empty STL container, back() will return some uninitialized memory, which
causes the crash.

of course returning a null pointer here is bad design anyway,
because perhaps somebody wants to store an actual null pointer in the stack...

http://hg.services.openoffice.org/cws/os144?cmd=changeset;node=82690329d55e

(btw, wouldn't it have been better to create a new issue for this regression?)

---------------------------------------------------------------------
Please do not reply to this automatically generated notification from
Issue Tracker. Please log onto the website and enter your comments.
http://qa.openoffice.org/issue_handling/project_issues.html#notification

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to