To comment on the following update, log in, then open the issue: http://www.openoffice.org/issues/show_bug.cgi?id=51304
------- Additional comments from [EMAIL PROTECTED] Wed Jun 29 07:16:34 -0700 2005 ------- - Please rename isDocumentEnhanced to isEnhancedForm, for reasons of consistency (and, well, better fitting semantics) - In FmXFormShell::isEnhancedForm, please don't duplicate the code from FmXFormShell::getDocumentType, but move it to a common method (getContextDocument or something like this) Duplicated code has a tendency to get out of sync, by fixing bugs in one instance only. - There are several more places in fmshell.cxx which simply compare getDocumentType with eEnhancedForm. They potentially bear the same problem, so please adjust them to use the new method, too. Same for one line in fmview.cxx and navigatortree.cxx, respectively. Other than that, I'd be fine with the patch. --------------------------------------------------------------------- Please do not reply to this automatically generated notification from Issue Tracker. Please log onto the website and enter your comments. http://qa.openoffice.org/issue_handling/project_issues.html#notification --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED] --------------------------------------------------------------------- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]
