@Josh, CommonCrypto is a system library in the Apple operation systems. It is open-sourced but macOS / iOS developers can use it as a system provided library, just #include <CommonCrypto/CommonCrypto.h>
AllJoyn has Crypto module (alljoyn/common/crypto) with the following implementations: builtin, cng and openssl. Builtin implementation is used when CRYPTO=builtin is set (files in the alljoyn/common/crypto/builtin folder). AllJoyn for macOS / iOS doesn't require the OpenSSL, it works well with CRYPTO=builtin and now 'builtin' is the default crypto implementation. Krystian found a patch that adds CRYPTO=commoncrypto, an implementation of Crypto module that uses CommonCrypto system library on the Apple operating system. So, the question is - should we add CRYPTO=commoncrypto support? It is not required but it can make sense as an option (like OpenSSL), CommonCrypto uses special CPU instructions: NEON (arm) and SSE3 (x86), it is faster and maybe safer. If it makes sense I can add it (it looks to be easy). Other question is (in the e-mail topic), should AllJoyn Core support latest OpenSSL? Maybe 'cng', 'openssl' are legacy / deprecated now and programmers should use 'builtin' implementation. -- Alexey > 9 дек. 2016 г., в 2:33, Josh Spain <jsp...@affinegy.com> написал(а): > > @Alexey, > > It is not clear to me what the difference is between ComonCrypto and > CRYPTO=buildin, when CRYPTO=buildin uses common/crypto/builtin > > Is it the same thing? > > Thanks, > Josh > > Josh Spain > Director of Engineering Affinegy, Inc. > t.512-535-1700 x1006 <tel:512-535-1700 x1006> > a. 1705 S Capital of Texas Hwy, Suite 310, Austin, TX 78746 USA > Website <http://affinegy.com/> Email <mailto:jsp...@affinegy.com> > <http://www.linkedin.com/in/joshspain> <http://twitter.com/affinegy> > Latest Tweet: <https://twitter.com/Affinegy> "In the physical world, advances > are constrained by physics." Silicon Valley Stumbles in World Beyond Software > - WSJ https://t.co/DCX4w5E7W8 <https://t.co/DCX4w5E7W8> Read More > <https://twitter.com/Affinegy/statuses/806692562568433664> > <https://twitter.com/Affinegy> > > On Thu, Dec 8, 2016 at 12:15 PM, Krystian Zlomek <kzlo...@affinegy.com > <mailto:kzlo...@affinegy.com>> wrote: > Can we reach some conclusion on this? > > Should I abandon https://git.allseenalliance.org/gerrit/#/c/7825/ > <https://git.allseenalliance.org/gerrit/#/c/7825/> or someone is going to > work on this? > > On Thu, Nov 24, 2016 at 8:41 AM, Alexey Solovyov <alex...@affinegy.com > <mailto:alex...@affinegy.com>> wrote: > Why we need to use CommonCrypto? CRYPTO=buildin works well, and we will use > it as default in build_core/SConscript for Apple platforms (see > https://git.allseenalliance.org/gerrit/#/c/9341/ > <https://git.allseenalliance.org/gerrit/#/c/9341/>) > > ps > CRYPTO=buildin uses: > > external/sha1/ > external/sha2/ > common/crypto/builtin/ > > > --- > Alexey > >> 24 нояб. 2016 г., в 4:20, Josh Spain <jsp...@affinegy.com >> <mailto:jsp...@affinegy.com>> написал(а): >> >> @Jorge, Olga or Alexey, can you determine if we already have support for >> CommonCrypto? If not would one of you review this changeset? It requires a >> rebase. >> >> Thanks, >> Josh >> >> >> On Nov 23, 2016 4:14 PM, "Kevin Kane via Alljoyn-core" >> <alljoyn-core@lists.alljoyn.org <mailto:alljoyn-core@lists.alljoyn.org>> >> wrote: >> I restored the change (actually >> https://git.allseenalliance.org/gerrit/#/c/7825/ >> <https://git.allseenalliance.org/gerrit/#/c/7825/>) but there’s a merge >> conflict with the current head of master so it can’t be rebased >> automatically. Is someone available to take a look at this? >> >> >> >> From: alljoyn-core-boun...@lists.alljoyn.org >> <mailto:alljoyn-core-boun...@lists.alljoyn.org> >> [mailto:alljoyn-core-boun...@lists.alljoyn.org >> <mailto:alljoyn-core-boun...@lists.alljoyn.org>] On Behalf Of Brad Kemp >> Sent: Wednesday, November 23, 2016 11:23 AM >> To: Krystian Zlomek <kzlo...@affinegy.com <mailto:kzlo...@affinegy.com>> >> Cc: Mathew Martineau <allseen-c...@lists.allseenalliance.org >> <mailto:allseen-c...@lists.allseenalliance.org>>; Way Vadhanasin >> <wayakorn.vadhana...@microsoft.com >> <mailto:wayakorn.vadhana...@microsoft.com>> >> >> >> Subject: Re: [Alljoyn-core] OpenSSL 1.1.0 >> >> >> >> Here is the checkin >> >> https://git.allseenalliance.org/gerrit/#/c/7849/ >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgit.allseenalliance.org%2Fgerrit%2F%23%2Fc%2F7849%2F&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=RdsNGuAb6CVBynW0W4KO5onbrst0uqBob2n1hCsKWkY%3D&reserved=0> >> Have at it. >> >> Regards >> >> Brad >> >> >> >> On Nov 23, 2016, at 2:07 PM, Krystian Zlomek <kzlo...@affinegy.com >> <mailto:kzlo...@affinegy.com>> wrote: >> >> >> >> Brad, do you have a link to Gerrit with your CommonCrypto change? We could >> evaluate it and possibly fix the Windows build problem. >> >> >> >> On Wed, Nov 23, 2016 at 7:38 PM, Brad Kemp <b...@beechwoods.com >> <mailto:b...@beechwoods.com>> wrote: >> >> We have been using the CommonCrypto internally instead of SSL. >> >> Brad >> >> >> >> On Nov 23, 2016, at 1:37 PM, Brad Kemp <b...@beechwoods.com >> <mailto:b...@beechwoods.com>> wrote: >> >> >> >> Marcello closed them because they sat un-attend for too long. The change >> broke the windows debug build. We don’t have windows machines here and could >> not figure out why a change in the MAC build cause windows breakage >> >> Brad >> >> >> >> On Nov 23, 2016, at 1:33 PM, Krystian Zlomek <kzlo...@affinegy.com >> <mailto:kzlo...@affinegy.com>> wrote: >> >> >> >> Strange, ASACORE-2957 and it's duplicate ASACORE-1826 are closed but Jira >> shows 0 git commits linked to that. >> >> >> >> >> >> On Wed, Nov 23, 2016 at 5:25 PM, Josh Spain <jsp...@affinegy.com >> <mailto:jsp...@affinegy.com>> wrote: >> >> According to ASACORE-2957 this has been completed already. It is closed. >> >> >> >> On Tue, Nov 22, 2016 at 4:12 PM, Brad Kemp <b...@beechwoods.com >> <mailto:b...@beechwoods.com>> wrote: >> >> Look at ASACORE 2957 we submitted it, but somehow it broke the Windows >> builds and we could never figure out why. >> >> This removes SSL from the MAC and replaces it with CommonCrypto >> >> Brad >> >> >> >> >> >> On Nov 22, 2016, at 4:56 PM, Josh Spain <jsp...@affinegy.com >> <mailto:jsp...@affinegy.com>> wrote: >> >> >> >> Okay, since we still support it (and esp. since it's default on Linux and >> ARM) we need to track this. @Thorsten, can you log a JIRA issue about this? >> >> >> >> Thanks, >> >> Josh >> >> >> >> Josh Spain >> Director of Engineering Affinegy, Inc. >> t.512-535-1700 x1006 <tel:512-535-1700%20x1006> >> a. 1705 S Capital of Texas Hwy, Suite 310, Austin, TX 78746 USA >> Website >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Faffinegy.com%2F&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=2EwjFlBNwkXswquPtFDvMv2%2BE%2BuYiZYY%2FZaRcq1PGnQ%3D&reserved=0> >> Email <mailto:jsp...@affinegy.com> >> >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Fjoshspain&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=4npPy1iJFkFbDlD521rOWOSUxpHCcocD6WwEw573dKU%3D&reserved=0> >> >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.com%2Faffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=vV34Y13AaUkfPaod8112nkh6xnDmNyHrCB7KS8Wvhvk%3D&reserved=0> >> Latest Tweet: >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=hDtzsJTLipE1TXDfz4Wcm8W8zjDlJSiGUB9DHOGABpA%3D&reserved=0> >> Building the buzz for their IPO ...This is Snapchat’s new Spectacles store >> in New York City https://t.co/AG1u809qRL >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ft.co%2FAG1u809qRL&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=1HZyDqtnaWnjycZyhoQz%2FxjZ86C4YbsTHKDChbsiW9U%3D&reserved=0> >> via @techcrunch >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Ftechcrunch&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=0QXH2BBH39cmfgl9AUr1pJ1F%2FDIXxttmNQ2E%2BNA9WEI%3D&reserved=0> >> >> Read More >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy%2Fstatuses%2F801009583619735552&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=fH8yabtnH6dUxPV4Thg%2Fvz9FZPpr4h1zJTYjx9QXJlU%3D&reserved=0> >> >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=hDtzsJTLipE1TXDfz4Wcm8W8zjDlJSiGUB9DHOGABpA%3D&reserved=0> >> >> >> On Tue, Nov 22, 2016 at 3:34 PM, Kevin Kane <kk...@microsoft.com >> <mailto:kk...@microsoft.com>> wrote: >> >> Based on build_core\SConscript, it’s still the default for Linux and Darwin >> on ARM. It’s an option for all platforms. >> >> >> >> From: Way Vadhanasin >> Sent: Tuesday, November 22, 2016 1:26 PM >> To: Josh Spain <jsp...@affinegy.com <mailto:jsp...@affinegy.com>>; Thorsten >> Alteholz <allj...@alteholz.de <mailto:allj...@alteholz.de>>; Krystian Zlomek >> <kzlo...@affinegy.com <mailto:kzlo...@affinegy.com>>; Kevin Kane >> <kk...@microsoft.com <mailto:kk...@microsoft.com>> >> Cc: allseen-c...@lists.allseenalliance.org >> <mailto:allseen-c...@lists.allseenalliance.org> >> Subject: RE: [Alljoyn-core] OpenSSL 1.1.0 >> >> >> >> I thought Linux is using it, but Kevin probably knows for sure. >> >> <> >> From: Josh Spain [mailto:jsp...@affinegy.com <mailto:jsp...@affinegy.com>] >> Sent: Tuesday, November 22, 2016 12:02 PM >> To: Thorsten Alteholz <allj...@alteholz.de <mailto:allj...@alteholz.de>>; >> Krystian Zlomek <kzlo...@affinegy.com <mailto:kzlo...@affinegy.com>>; Way >> Vadhanasin <wayakorn.vadhana...@microsoft.com >> <mailto:wayakorn.vadhana...@microsoft.com>> >> Cc: allseen-c...@lists.allseenalliance.org >> <mailto:allseen-c...@lists.allseenalliance.org> >> Subject: Re: [Alljoyn-core] OpenSSL 1.1.0 >> >> >> >> Krystian or Way, >> >> >> >> Do either of you know if OpenSSL is mandatory or default for any platform? >> Do you know if it is still supported as an option? I'm pretty sure we >> removed it from iOS and Android. >> >> >> >> Thanks, >> >> Josh >> >> >> >> Josh Spain >> Director of Engineering Affinegy, Inc. >> t.512-535-1700 x1006 <tel:512-535-1700%20x1006> >> a. 1705 S Capital of Texas Hwy, Suite 310, Austin, TX 78746 USA >> Website >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Faffinegy.com%2F&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=2EwjFlBNwkXswquPtFDvMv2%2BE%2BuYiZYY%2FZaRcq1PGnQ%3D&reserved=0> >> Email <mailto:jsp...@affinegy.com> >> >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fwww.linkedin.com%2Fin%2Fjoshspain&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=4npPy1iJFkFbDlD521rOWOSUxpHCcocD6WwEw573dKU%3D&reserved=0> >> >> <https://na01.safelinks.protection.outlook.com/?url=http%3A%2F%2Ftwitter.com%2Faffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=vV34Y13AaUkfPaod8112nkh6xnDmNyHrCB7KS8Wvhvk%3D&reserved=0> >> Latest Tweet: >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=hDtzsJTLipE1TXDfz4Wcm8W8zjDlJSiGUB9DHOGABpA%3D&reserved=0> >> Building the buzz for their IPO ...This is Snapchat’s new Spectacles store >> in New York City https://t.co/AG1u809qRL >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ft.co%2FAG1u809qRL&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013412164&sdata=1HZyDqtnaWnjycZyhoQz%2FxjZ86C4YbsTHKDChbsiW9U%3D&reserved=0> >> via @techcrunch >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2Ftechcrunch&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=S%2BZeGrssMYEsSJNdsRkfA42evlEsidT2LrK5eIwRPp4%3D&reserved=0> >> >> Read More >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy%2Fstatuses%2F801009583619735552&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=o445QDlqSsNkzgTNJ5GBLW67cUiJcBxDMAgLLOy3TEU%3D&reserved=0> >> >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Ftwitter.com%2FAffinegy&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=pftbeevm9g9eTaV9nVb%2BDroAPemEPCzUiNtZssyxgxc%3D&reserved=0> >> >> >> On Tue, Nov 22, 2016 at 1:23 PM, Thorsten Alteholz <allj...@alteholz.de >> <mailto:allj...@alteholz.de>> wrote: >> >> >> >> On Mon, 21 Nov 2016, Josh Spain wrote: >> >> Someone please correct me if I'm wrong, but I don't think we're using >> OpenSSL on any platform any longer. >> >> >> Hmm, according to [1] the default_crypto in the master branch is set to >> 'openssl' on Linux and Darwin (at least for non-x86). >> According to [2] one can use the latest version of OpenSSL for cryptographic >> functions. >> So are these information outdated and the builtin stuff shall be better >> used? Is this also true for older versions or just for 16.10 and later? >> >> Thorsten >> >> >> [1] >> https://cgit.allseenalliance.org/core/alljoyn.git/tree/build_core/SConscript >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fcgit.allseenalliance.org%2Fcore%2Falljoyn.git%2Ftree%2Fbuild_core%2FSConscript&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=QbbIqHB50auhel%2FDcB2D4x6SXj5yhyHlgRKlZH3cDZs%3D&reserved=0> >> [2] >> https://allseenalliance.org/framework/documentation/develop/building/linux/build-source >> >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Fallseenalliance.org%2Fframework%2Fdocumentation%2Fdevelop%2Fbuilding%2Flinux%2Fbuild-source&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=7hDX1A8S0ngMYqXzPzvDD3i7ivuZHjcOc%2B534DAjr%2FA%3D&reserved=0> >> >> >> >> _______________________________________________ >> Alljoyn-core mailing list >> Alljoyn-core@lists.alljoyn.org <mailto:Alljoyn-core@lists.alljoyn.org> >> https://lists.alljoyn.org/mailman/listinfo/alljoyn-core >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.alljoyn.org%2Fmailman%2Flistinfo%2Falljoyn-core&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=ZvvhbgyaAHbONG9MrftIxbKOTpArLf%2BT%2BR2iBIa0iu0%3D&reserved=0> >> >> >> >> >> _______________________________________________ >> Alljoyn-core mailing list >> Alljoyn-core@lists.alljoyn.org <mailto:Alljoyn-core@lists.alljoyn.org> >> https://lists.alljoyn.org/mailman/listinfo/alljoyn-core >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.alljoyn.org%2Fmailman%2Flistinfo%2Falljoyn-core&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=ZvvhbgyaAHbONG9MrftIxbKOTpArLf%2BT%2BR2iBIa0iu0%3D&reserved=0> >> >> >> >> >> >> _______________________________________________ >> Alljoyn-core mailing list >> Alljoyn-core@lists.alljoyn.org <mailto:Alljoyn-core@lists.alljoyn.org> >> https://lists.alljoyn.org/mailman/listinfo/alljoyn-core >> <https://na01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.alljoyn.org%2Fmailman%2Flistinfo%2Falljoyn-core&data=02%7C01%7Ckkane%40microsoft.com%7C9a727e021e254ec9f07008d413d84609%7C72f988bf86f141af91ab2d7cd011db47%7C1%7C0%7C636155267013422168&sdata=ZvvhbgyaAHbONG9MrftIxbKOTpArLf%2BT%2BR2iBIa0iu0%3D&reserved=0> >> >> >> >> >> >> >> >> >> >> >> >> _______________________________________________ >> Alljoyn-core mailing list >> Alljoyn-core@lists.alljoyn.org <mailto:Alljoyn-core@lists.alljoyn.org> >> https://lists.alljoyn.org/mailman/listinfo/alljoyn-core >> <https://lists.alljoyn.org/mailman/listinfo/alljoyn-core> >> > > >
_______________________________________________ Alljoyn-core mailing list Alljoyn-core@lists.alljoyn.org https://lists.alljoyn.org/mailman/listinfo/alljoyn-core
