Regarding #2: There are known problems with the Jenkins verification, there are JIRA tickets open, and people are working on it. In the meantime, the committers have been overriding the build failures when they look like the known issues and the change doesn’t look like it’s causing them. A quick look suggests this is likely true for your change, so I’d suggest going ahead with adding ‘cr-core’ to your review so it can get looked at.
I’m unaware of the current status of the string-migration branch or why it didn’t get merged back into master. Now that the JIRA tickets are assigned to you, I expect it would be up to you to assess the state of the branch, determine whether or not the work is complete, and when it is, submit the merge to master. From: [email protected] [mailto:[email protected]] On Behalf Of Krystian Zlomek Sent: Friday, March 11, 2016 2:38 AM To: [email protected] Subject: [Allseen-core] ASACORE-2276 status on branch feature/string-migration, please comment Hi, ASACORE-2276 Migrate qcc::String to std::string - Phase 1 seems to be already implemented according to description on branch feature/string-migration. Also ASACORE-2276 links to: · blocks: ASACORE-2292 Remove StringMapKey · is blocked by: ASACORE-2538 AboutData::GetSupportedLanguages() can return a dangling pointer Both issues are resolved on branch feature/string-migration by commits: commit for ASACORE-2292 (no Jira ID in commit) commit 5fac9916e42d05300a959ae4d3059ff8cf7641f4 Author: Steve Kinneberg <[email protected]<mailto:[email protected]>> Date: Mon Sep 21 14:36:22 2015 -0700 Remove qcc::StringMapKey. commit for ASACORE-2538 (no Jira ID in commit) commit 0478168837cb4d5d9c695475629c918bb7a623d4 Author: Todd Malsbary <[email protected]<mailto:[email protected]>> Date: Wed Dec 2 09:50:11 2015 -0800 Fix build and test errors. 1. Does anyone know if something was missing on branch feature/string-migration so it was not yet merged to master (taking into account status described above)? 2. When I merged latest changes from master to string-migration and pushed, Jenkins failed my build on Linux (ASACORE-2725) and on Windows. Could someone take a look on result - https://build.allseenalliance.org/ci/job/windows10-test-verify/116/console<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fbuild.allseenalliance.org%2fci%2fjob%2fwindows10-test-verify%2f116%2fconsole&data=01%7c01%7ckkane%40microsoft.com%7ca55b5d67d0cc4d2218f508d3499935d9%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=Lu6Na090x0Z4Y%2fSv5pFzo70jsnKyvRkCV3tiFIlv%2bfA%3d> - and tell me what might be wrong with SecurityAuthenticationTest2 which timed out? Maybe it's a known issue? Regards, Krystian
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
