I would be more in favor of making KeyStore.h part of the public API. Technically it is possible for someone to copy the KeyStore.h file from the source code repository into their own repository and use the undocumented KeyStore API implemented in the AllJoyn shared library.
However, since KeyStore is currently an undocumented API it should not be "illegal" to make any changes we want before adding it to the public API, as long as it doesn't impact the KeyStoreListener public API. By the way, I logged ASACORE-2774 <https://jira.allseenalliance.org/browse/ASACORE-2774> about this problem. -Josh On Fri, Mar 18, 2016 at 2:01 PM, Daniel Mihai <[email protected]> wrote: > Good catch, Josh! > > > > At the moment I am glad to hear that KeyStoreListener has been broken for > a long time (!). If that’s the case, then we should be safer to improve the > design of the KeyStore class in 16.04. Way is currently working on those > improvements. Way’s fixes do not address the problem you described below. > > > > If KeyStoreListener has been broken for a long time, I think we should ask > ourselves if anyone needs it to be Public. If nobody needs it, and it has > been broken for a long time, we should consider removing KeyStoreListener > from Publics sometime. > > > > Dan > > > > *From:* [email protected] [mailto: > [email protected]] *On Behalf Of *Josh Spain > *Sent:* Friday, March 18, 2016 10:51 AM > *To:* [email protected] > *Subject:* [Allseen-core] KeyStore and KeyStoreListener > > > > Can anyone tell me why KeyStoreListener.h is public and KeyStore.h is not? > It's not possible to implement a KeyStoreListener when KeyStore.h is > located under alljoyn_core/src. > > > > Apparently this has been the case for a long time, but I suppose nobody > has attempted to implement a KeyStoreListener. > > > > Thanks, > > Josh >
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
