Conference call/technical discussion sounds useful indeed! Ideally Marcello should join us for this conference call – but I don’t remember when he comes back in town.
Thanks! From: Andrey Krokhin [mailto:[email protected]] Sent: Thursday, March 31, 2016 12:35 PM To: Daniel Mihai <[email protected]> Cc: Josh Spain <[email protected]>; [email protected] Subject: Re: [Allseen-core] Custom Error Messages for Properties (ASACORE-1811) Dan, I agree. I'll have to ask someone (probably Josh or Ry) how to do steps 1 and 2. Right now, several existing unit tests are failing with my changes. (C++ tests) PerfTest.Properties_SettingNoSuchProperty PerfTest.Properties_SettingReadOnlyProperty (C tests) BusObjectTest.get_property_handler BusObjectTest.set_property_handler BusObjectTest.get_propertyasync_handler BusObjectTest.set_propertyasync_handler It seems that all of those tests are failing due to a timeout. I can see where the wait loop is entered in ProxyBusObject::MethodCall, but I don't see why my changes would cause that. Right now, I am trying to revert my changes one by one to see if I can get the tests to pass. Once that is done, I can start thinking about adding unit tests and C projection. Meanwhile, I'd still like to have a conference call to go over my changes and make sure everybody understands the new interfaces. - Andrey On Thu, Mar 31, 2016 at 12:23 PM, Daniel Mihai <[email protected]<mailto:[email protected]>> wrote: Hi Josh, Based on my previous experience in the Core WG, I believe the next steps are: 1. Request a new branch off master (e.g. feature/ASACORE-1811) 2. Place the changes from https://git.allseenalliance.org/gerrit/#/c/7165/<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.allseenalliance.org%2fgerrit%2f%23%2fc%2f7165%2f&data=01%7c01%7cDaniel.Mihai%40microsoft.com%7cc8e75677aee44732e63b08d3599b8186%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=HEWvskJfb5B8WazZ4QhgLAaDYxBCfe9usxOmIHHlCDI%3d> into the new branch 3. Add C projection for the new APIs 4. Add unit tests for both CPP and C APIs 5. When the tests are passing, request to merge into master branch I think it’s already too late for adding new APIs in RB16.04. After completing the steps above, it will be even later. So targeting the master branch and the 16.10 release seems most realistic. Dan From: [email protected]<mailto:[email protected]> [mailto:[email protected]<mailto:[email protected]>] On Behalf Of Josh Spain Sent: Tuesday, March 29, 2016 3:56 PM To: [email protected]<mailto:[email protected]> Subject: [Allseen-core] Custom Error Messages for Properties (ASACORE-1811) It was brought up in code review that we need to discuss breaking changes (deprecation) introduced in the fix for ASACORE-1811. We will discuss in Thursday's Core WG call. For a brief overview, here's what we'll be discussing: * When Get/Set Properties fails the only error returned is ER_BUS_REPLY_IS_ERROR_MESSAGE, and no additional error information is returned. * HAE WG needs this fix as soon as possible. * This fix introduces deprecation of existing APIs and replacement with new ones. * Andrey Krokhin (Affinegy) is working on this currently and we are going through some code reviews both internally and externally on the changes. * Is this something we can put in the 16.04 release? Thanks, Josh [http://i61.tinypic.com/5luc5u.png] Josh Spain, Director of Engineering, Affinegy 1705 S. Capital of Texas Hwy, Ste. 310, Austin, TX, 78746 512.535.1700<tel:512.535.1700> [email protected]<mailto:[email protected]> http://affinegy.com<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faffinegy.com%2f&data=01%7c01%7cDaniel.Mihai%40microsoft.com%7ca3527f00f06a4e34207408d3582560b0%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=uM7eQ13%2faz0sOd7nnSchjqXJaLqMy%2fnCicb71eayiNs%3d> _______________________________________________ Allseen-core mailing list [email protected]<mailto:[email protected]> https://lists.allseenalliance.org/mailman/listinfo/allseen-core<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2flists.allseenalliance.org%2fmailman%2flistinfo%2fallseen-core&data=01%7c01%7cDaniel.Mihai%40microsoft.com%7cc8e75677aee44732e63b08d3599b8186%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=NqLNXCzPOhz4aprs2tUjIi6PFCEEJojIE6z8SRAA4Go%3d> -- [http://i61.tinypic.com/5luc5u.png.] Andrey Krokhin, Software Engineer Affinegy 1705 S. Capital of Texas Hwy, Ste. 310, Austin, TX, 78746 512.535.1700<tel:512.535.1700> [email protected]<mailto:[email protected]> http://affinegy.com<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faffinegy.com%2f&data=01%7c01%7cDaniel.Mihai%40microsoft.com%7cc8e75677aee44732e63b08d3599b8186%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=5nuNf4nmGuu6X4bsMZUQaKuQCawmaj1YtzIGScfGz%2bM%3d>
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
