Committers will still be on the path in a branch. Gerrit’s workflow lends itself to changes being examined when they’re merged into the branch, and not to doing one massive review when the branch merges back into the parent. Speaking only for myself, I prefer it to one massive review at the end.
I believe Jenkins CI builds will automatically run as they already do for master and RB16.04. I’d suggest keeping these on as it will help identify issues that would block the parent merge early, instead of discovering them at the end when the parent merge gets put up to Gerrit, the CI builds fail, and you have to figure out what in this list of changes broke it. But we can accept things being broken in the branch if need be, with the understanding everything needs to be resolved before the merge back to parent. If so, from then on you may want to triage the Jenkins failures to make sure there aren’t additional failures being introduced. As for the name, a couple ideas: feature/iOS-16.04? RB16.04-iOS? I don’t think we’ve done a branch off of a release branch before, so I’m unaware of any naming precedent. From: [email protected] [mailto:[email protected]] On Behalf Of Josh Spain Sent: Thursday, July 7, 2016 3:30 PM To: Ry Jones <[email protected]> Cc: Arvind Padole <[email protected]>; Kishore Kolli <[email protected]>; [email protected]; Way Vadhanasin <[email protected]> Subject: Re: [Allseen-core] Branch for iOS changes How about 16.04a? On Thu, Jul 7, 2016 at 4:41 PM, Ry Jones <[email protected]<mailto:[email protected]>> wrote: I can create a branch off of RB16.04, once we have a name for the branch On Thu, Jul 7, 2016 at 1:51 PM, Daniel Mihai <[email protected]<mailto:[email protected]>> wrote: My understanding is that Committers will be in the path even in a separate branch. This might be a good time to propose someone from Affinegy to become a SCL/Router Committer. That Committer would be responsible mainly for merging the iOS changes – at least for now. I would prefer a separate branch for iOS, just in case something very urgent will up for 16.04a before the iOS changes will be ready. Thanks, Dan From: Lioy, Marcello [mailto:[email protected]<mailto:[email protected]>] Sent: Thursday, July 7, 2016 1:42 PM To: Josh Spain <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Ry Jones <[email protected]<mailto:[email protected]>> Cc: Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes + Dan & Ry I think we agreed to do it on a branch off of 16.04 so that we didn’t need to worry about the committers getting in the path, particularly on the release branch. I believe Ry also indicated it would be possible at the very least to hand trigger verification builds, or (if possible) actually have automatic verify builds on that branch. Dan, Ry, is that your recollection also? From: Josh Spain [mailto:[email protected]] Sent: Thursday, July 07, 2016 1:33 PM To: Lioy, Marcello <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Cc: Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>> Subject: Branch for iOS changes Marcello and Core Team, Should we be pushing iOS changes to RB16.04 or should we create a feature branch off of RB16.04 and push to it? Thanks, Josh [http://i61.tinypic.com/5luc5u.png] Josh Spain, Director of Engineering, Affinegy 1705 S. Capital of Texas Hwy, Ste. 310, Austin, TX, 78746 512.535.1700<tel:512.535.1700> [email protected]<mailto:[email protected]> http://affinegy.com<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faffinegy.com%2f&data=01%7c01%7ckkane%40microsoft.com%7cd054530701ce408663de08d3a6b65c82%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=1NsKgfhL9XngF07V%2fapT5wMH0NatqdU%2fOx5PB%2bCYDnA%3d>
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
