I see Jorge has pushed a lot of commits to Gerrit for the new branch. Jorge, did you author all of these? And if so, have they been through any sort of internal review? If not, can you ask someone who’s knowledgeable about iOS to review before merging?
From: Lioy, Marcello [mailto:[email protected]] Sent: Thursday, July 14, 2016 1:07 PM To: Ry Jones <[email protected]> Cc: Greg Zaverucha <[email protected]>; Way Vadhanasin <[email protected]>; Kevin Kane <[email protected]>; Daniel Mihai <[email protected]>; Josh Spain <[email protected]>; [email protected]; Kishore Kolli <[email protected]>; Jorge Martinez <[email protected]>; Arvind Padole <[email protected]> Subject: RE: Branch for iOS changes Thank you sir! From: Ry Jones [mailto:[email protected]] Sent: Thursday, July 14, 2016 11:48 AM To: Lioy, Marcello <[email protected]<mailto:[email protected]>> Cc: Greg Zaverucha <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: Re: Branch for iOS changes yes, at the same time I added him to Gerrit https://wiki.allseenalliance.org/tsc/committers<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fwiki.allseenalliance.org%2ftsc%2fcommitters&data=01%7c01%7ckkane%40microsoft.com%7c24b89d153e7d40aa3c8308d3ac225c68%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=HIicWhCNRgRTpoKpRBkOMGvwGti1pNVz6C3gZqB1W98%3d> On Thu, Jul 14, 2016 at 11:41 AM, Lioy, Marcello <[email protected]<mailto:[email protected]>> wrote: Thanks Ry – did you get a chance to update the web/wiki page? From: Ry Jones [mailto:[email protected]<mailto:[email protected]>] Sent: Thursday, July 14, 2016 10:19 AM To: Lioy, Marcello <[email protected]<mailto:[email protected]>> Cc: Greg Zaverucha <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: Re: Branch for iOS changes Branch created: https://git.allseenalliance.org/cgit/core/alljoyn.git/log/?h=feature/iOS_updates<https://na01.safelinks.protection.outlook.com/?url=https%3a%2f%2fgit.allseenalliance.org%2fcgit%2fcore%2falljoyn.git%2flog%2f%3fh%3dfeature%2fiOS_updates&data=01%7c01%7ckkane%40microsoft.com%7c24b89d153e7d40aa3c8308d3ac225c68%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oe8WWLoYsToj%2fohFS9PUmYnU6Pwk9txqkF%2fPeIsi1kQ%3d> 73d8f14c807c972fb3c0f8a0cde2f62d18d3eb91 Jorge added as a committer On Thu, Jul 14, 2016 at 9:30 AM, Lioy, Marcello <[email protected]<mailto:[email protected]>> wrote: Thanks Greg. Based on discussions with Philip and others I don’t think this appointment needs to go to the TSC. Ry please grant Jorge a committer privileges, and update the Wiki. I believe the expectation is that he focusses on the iOS specific part of the code until committers are comfortable with him +2 more broadly. Please correct that if there is a misunderstanding. From: Greg Zaverucha [mailto:[email protected]<mailto:[email protected]>] Sent: Wednesday, July 13, 2016 1:16 PM To: Lioy, Marcello <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes I approve as well. Greg From: Lioy, Marcello [mailto:[email protected]] Sent: Wednesday, July 13, 2016 10:10 AM To: Way Vadhanasin <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; Greg Zaverucha <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes I guess that is a majority, since I will also add my +1 giving us 4 out of 5. Will give Greg today to respond before moving forward. No clarity on the TSC front, in discussions with the guardians of the project. From: Way Vadhanasin [mailto:[email protected]] Sent: Wednesday, July 13, 2016 8:34 AM To: Kevin Kane <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Lioy, Marcello <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; Greg Zaverucha <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes +1 Sent from my Windows 10 phone [14384 - 16.0.7167.4018] From: Kevin Kane<mailto:[email protected]> Sent: Wednesday, July 13, 2016 7:55 AM To: Daniel Mihai<mailto:[email protected]>; Lioy, Marcello<mailto:[email protected]>; Josh Spain<mailto:[email protected]>; Way Vadhanasin<mailto:[email protected]>; Greg Zaverucha<mailto:[email protected]> Cc: Ry Jones<mailto:[email protected]>; [email protected]<mailto:[email protected]>; Kishore Kolli<mailto:[email protected]>; Jorge Martinez<mailto:[email protected]>; Arvind Padole<mailto:[email protected]> Subject: RE: Branch for iOS changes I also approve. From: Daniel Mihai Sent: Tuesday, July 12, 2016 3:30 PM To: Lioy, Marcello <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Greg Zaverucha <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes I approve adding Jorge Martinez as a Committer for alljoyn.git. Dan From: Lioy, Marcello [mailto:[email protected]] Sent: Tuesday, July 12, 2016 3:27 PM To: Josh Spain <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Kevin Kane <[email protected]<mailto:[email protected]>>; Greg Zaverucha <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes + Kevin & Greg Checking wither this needs to go to TSC. In the meantime do the current committers on the alljoyn.git project approve (Way, Dan, Greg, Kevin)? From: Josh Spain [mailto:[email protected]] Sent: Tuesday, July 12, 2016 2:20 PM To: Lioy, Marcello <[email protected]<mailto:[email protected]>> Cc: Ry Jones <[email protected]<mailto:[email protected]>>; Daniel Mihai <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: Re: Branch for iOS changes Hi Marcello, Since Jorge is already a committer on two core projects let's make Jorge the committer on this one also. The proposed branch name is fine with me. Thanks, Josh [Image removed by sender.] Josh Spain, Director of Engineering, Affinegy 1705 S. Capital of Texas Hwy, Ste. 310, Austin, TX, 78746 512.535.1700<tel:512.535.1700> [email protected]<mailto:[email protected]> http://affinegy.com<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faffinegy.com%2f&data=01%7c01%7cgregz%40microsoft.com%7c5fc9e7342b864c55dc4b08d3ab408904%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oTzO6e65zrO5K3cnI51Il7t6%2fcO%2fslKWpS9upqNcGbw%3d> On Fri, Jul 8, 2016 at 12:45 PM, Lioy, Marcello <[email protected]<mailto:[email protected]>> wrote: We can propose someone as a committer for the iOS area – is Kishore the right guy, or Jorge? Assuming Josh you are on board I would call the branch ‘iOS_updates’ the 16.04 should be implied bu the fact that it is coming off the release branch. Calling it 16.04a would be confusing. Ry can we have verifiy builds set up to run automatically for the iOS branch? From: Ry Jones [mailto:[email protected]<mailto:[email protected]>] Sent: Thursday, July 07, 2016 2:41 PM To: Daniel Mihai <[email protected]<mailto:[email protected]>> Cc: Lioy, Marcello <[email protected]<mailto:[email protected]>>; Josh Spain <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>>; Way Vadhanasin <[email protected]<mailto:[email protected]>>; Arvind Padole <[email protected]<mailto:[email protected]>> Subject: Re: Branch for iOS changes I can create a branch off of RB16.04, once we have a name for the branch On Thu, Jul 7, 2016 at 1:51 PM, Daniel Mihai <[email protected]<mailto:[email protected]>> wrote: My understanding is that Committers will be in the path even in a separate branch. This might be a good time to propose someone from Affinegy to become a SCL/Router Committer. That Committer would be responsible mainly for merging the iOS changes – at least for now. I would prefer a separate branch for iOS, just in case something very urgent will up for 16.04a before the iOS changes will be ready. Thanks, Dan From: Lioy, Marcello [mailto:[email protected]<mailto:[email protected]>] Sent: Thursday, July 7, 2016 1:42 PM To: Josh Spain <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]>; Daniel Mihai <[email protected]<mailto:[email protected]>>; Ry Jones <[email protected]<mailto:[email protected]>> Cc: Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>> Subject: RE: Branch for iOS changes + Dan & Ry I think we agreed to do it on a branch off of 16.04 so that we didn’t need to worry about the committers getting in the path, particularly on the release branch. I believe Ry also indicated it would be possible at the very least to hand trigger verification builds, or (if possible) actually have automatic verify builds on that branch. Dan, Ry, is that your recollection also? From: Josh Spain [mailto:[email protected]] Sent: Thursday, July 07, 2016 1:33 PM To: Lioy, Marcello <[email protected]<mailto:[email protected]>>; [email protected]<mailto:[email protected]> Cc: Kishore Kolli <[email protected]<mailto:[email protected]>>; Jorge Martinez <[email protected]<mailto:[email protected]>> Subject: Branch for iOS changes Marcello and Core Team, Should we be pushing iOS changes to RB16.04 or should we create a feature branch off of RB16.04 and push to it? Thanks, Josh [Image removed by sender.] Josh Spain, Director of Engineering, Affinegy 1705 S. Capital of Texas Hwy, Ste. 310, Austin, TX, 78746 512.535.1700<tel:512.535.1700> [email protected]<mailto:[email protected]> http://affinegy.com<https://na01.safelinks.protection.outlook.com/?url=http%3a%2f%2faffinegy.com%2f&data=01%7c01%7cgregz%40microsoft.com%7c5fc9e7342b864c55dc4b08d3ab408904%7c72f988bf86f141af91ab2d7cd011db47%7c1&sdata=oTzO6e65zrO5K3cnI51Il7t6%2fcO%2fslKWpS9upqNcGbw%3d>
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
