If you can bring your stuff in line with Georges than I am fine, but it needs to happen soon. I am concerned about one change that is 1700 lines that doesn't appear to have had any recent review.
From: Paul Sigurdson [mailto:[email protected]] Sent: Friday, September 23, 2016 11:23 AM To: Lioy, Marcello <[email protected]> Cc: Arvind Padole <[email protected]>; Josh Spain <[email protected]>; Way Vadhanasin <[email protected]>; [email protected] Subject: Re: [Allseen-core] Gerrit backlog Oh, the BusAttachment.java and BusAttachmentTest.java files have changes both in my stuff and in Georges. On Sep 23, 2016, at 1:19 PM, Paul Sigurdson <[email protected]<mailto:[email protected]>> wrote: Also, my Java commits were passing the Jenkins builds as recently as yesterday. -Paul On Sep 23, 2016, at 1:15 PM, Lioy, Marcello <[email protected]<mailto:[email protected]>> wrote: I have merged a couple of Jorge's ObjC changes, but others either have -1 or merge conflicts/dependencies. I also noticed that a whole lot of the java changes are now failing Jenkins. Does anyone have any insight into what is going on there? Another specific concern I have is that two of Paul's changes (8905<https://git.allseenalliance.org/gerrit/8905> and 8871<https://git.allseenalliance.org/gerrit/8871>) for dynamic interfaces conflict with three changes related to Secuirty 2.0: <image001.gif>ASACORE-3156 Sec2.0 GetPermissionConfigurator<https://git.allseenalliance.org/gerrit/#/c/8869/4> <image001.gif>ASACORE-3156 Sec2 ApplicationStateListener<https://git.allseenalliance.org/gerrit/#/c/8881/5> <image001.gif>ASACORE-3156 Sec2 PermissionConfigurationListener<https://git.allseenalliance.org/gerrit/#/c/8877/3> Given where we are in the release process I am wondering if we want to skip adding that feature (given the conflicts and that it is easily 3K of new code), I have -1 those two plus the others I saw in this feature set (8903<https://git.allseenalliance.org/gerrit/8903>, 8873<https://git.allseenalliance.org/gerrit/8873>, 8905<https://git.allseenalliance.org/gerrit/8905>, and 8797<https://git.allseenalliance.org/gerrit/8797>). Thoughts? _______________________________________________ Allseen-core mailing list [email protected]<mailto:[email protected]> https://lists.allseenalliance.org/mailman/listinfo/allseen-core
_______________________________________________ Allseen-core mailing list [email protected] https://lists.allseenalliance.org/mailman/listinfo/allseen-core
