It should be possible to call the XmlManifestConverter from inside the JNI 
code, to do the conversion between XML and Manifest object there, before 
calling the C++ API. We did something like this for the C API in 
alljoyn_c\src\SecurityApplicationProxy.cc. This is another option if we don’t 
want to add an XML-using API to C++.

Regardless, since it seems natural to use a bus attachment as a key container 
in a security manager, and we already have APIs for signing certificates with 
the bus attachment’s private key, I think it makes sense to expose similar 
functionality for manifests in the Java layer.

I also agree with not exposing CredentialAccessor.

From: [email protected] 
[mailto:[email protected]] On Behalf Of George Tang
Sent: Monday, October 24, 2016 10:35 PM
To: allseen-core <[email protected]>
Subject: [Allseen-core] API change

Hi,

I have discussed with Kevin Kane an API change to core.  I would like to add 
another version of ComputeThumbprintAndSignManifest to PermissionConfigurator 
that takes a xml string instead of a manifest object.

XmlManifestConverter is not public, so it may not be conventionally accessible 
from the Java bindings. I could use include 
"../../../alljoyn_core/src/XmlManifestConverter.cc" but I'm sure this is not 
good practice.

This issue blocks the java bindings from being able to call Reset, 
StartManagement, EndManagement successfully.

Another solution that doesn't change the c++ API would be making a public 
function in java to get the busAttachment's private Key. This would be 
inconsistent with the c++ bindings in that c++ doesn't expose this.

I haven't started work on it, but from my investigation, I think it will take 
me 8 additional hours not including the code review process.
_______________________________________________
Allseen-core mailing list
[email protected]
https://lists.allseenalliance.org/mailman/listinfo/allseen-core

Reply via email to