I like the way this works, but I think the exception handling should be moved into a contextmanager or a decorator so that it can be easily reused. If you look at [#6526] you'll notice that all the ToolImporters now have their own `@task` wrappers, each of which will need this same behavior.
--- ** [tickets:#6530] Improve error handling / reporting on tool importer failure** **Status:** in-progress **Labels:** import **Created:** Wed Aug 07, 2013 08:46 PM UTC by Cory Johns **Last Updated:** Wed Aug 28, 2013 06:24 PM UTC **Owner:** Cory Johns Currently, if a tool importer fails, the only record of the failure is in the monq_task record. Failures need to be caught and the users notified in some way. A catch-all should be put in place in the `import_tool` task, but individual tools may want to handle reporting differently, such as the repo clone failure notification that is already in place and we need to ensure that the catch-all doesn't duplicate any per-tool handling. Partial imports also need to be considered and we might want to decide if a partially failed import is worth rolling back the entire tool import or if the importer should handle a failed ticket, e.g., gracefully and continue to import the rest of the tickets if possible. --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
