Well the tests all pass, but I'm not seeing a `Sender:` header in any of my notification emails when testing. A couple examples:
~~~~ To: "[test6549:wiki] " <h...@wiki.test6549.p.tvansteenburgh-1024.sb.sf.net> From: "Administrator 1" <adm...@users.sf.net> Reply-To: "[test6549:wiki] " <h...@wiki.test6549.p.tvansteenburgh-1024.sb.sf.net> Subject: [test6549:wiki] Discussion for Home page Message-ID: </p/test6549/wiki/Home/e7ddc77dc4cdd73732d30daac76113e12316af44.w...@test6549.p.sourceforge.net> Date: Wed, 23 Oct 2013 14:08:58 +0000 To: "[test6549:gfarm] " <7...@gfarm.test6549.p.tvansteenburgh-1024.sb.sf.net> From: "Administrator 1" <adm...@users.sf.net> Reply-To: "[test6549:gfarm] " <7...@gfarm.test6549.p.tvansteenburgh-1024.sb.sf.net> Subject: [test6549:gfarm] #730 A test ticket Message-ID: </p/test6549/gfarm/730/a951b84c07a67d35c8204e605824ba258cc609f1.gf...@test6549.p.sourceforge.net> Date: Wed, 23 Oct 2013 13:56:09 +0000 ~~~~ Not sure if I'm missing something...can you provide instructions for how you tested? One more thing - I noticed some direct calls to `sendmail.post()` in `forgetracker/model/ticket.py`. Seems like those wouldn't ever get the new `Sender:` header? --- ** [tickets:#6249] Use a stable Sender: header in email notifications [ss4075]** **Status:** in-progress **Labels:** support p3 42cc **Created:** Fri May 17, 2013 04:31 PM UTC by Dave Brondsema **Last Updated:** Mon Oct 21, 2013 03:38 PM UTC **Owner:** nobody Email notifications have varying From addresses (e.g. the ticket submitter). Notifications should have a `Sender:` header specified which refers to the system sending rather than the end-user we're doing it on behalf of. This should be a stable value so that it can be used in mail filters (e.g. mailman). Perhaps the tool's email address would work well. Test how common clients (e.g. gmail) display it and if it affects replies at all. --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
