Since this little pattern is repeated so often (render username, with href, but 
only if not anonymous), it would be great to see it rolled up into a macro. 
Unfortunately `user_link()` is already taken, but one idea is to rename that to 
`email_link()` (doesn't look like it's used in very many places), and create a 
`user_link(user, avatar=False, size=16)` macro. If `avatar=True`, call 
`lib.gravatar_or_name()`, otherwise just use `display_name`.


---

** [tickets:#4723] Don't link to user-project when Anonymous**

**Status:** in-progress
**Labels:** 42cc 
**Created:** Wed Aug 15, 2012 06:55 PM UTC by Dave Brondsema
**Last Updated:** Wed Nov 20, 2013 02:27 PM UTC
**Owner:** nobody

Links go to "/u/userid-None/" which 404s of course.  They used to go to 
"/u/*anonymous/" but that 404s too.

We shouldn't provide links if the user is anonymous.  Comments is a common 
place for this to occur, but also need to look out for ticket 
creators/assigned-to and wiki contributors, probably many more.


---

Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed 
to https://sourceforge.net/p/allura/tickets/

To unsubscribe from further messages, a project admin can change settings at 
https://sourceforge.net/p/allura/admin/tickets/options.  Or, if this is a 
mailing list, you can unsubscribe from the mailing list.

Reply via email to