Looks good. Just making a small tweak to simplify logic: ~~~~ ::diff - if app_config: - project = Project.query.get(_id=app_config.project_id) - app = app_config.load()(project, app_config) - return has_access(app, perm, user, project) + return has_access(app_config, perm, user) ~~~~
This works since app_config.project automatically loads via app_config.project_id. And has_access checks for None and also loads the project via the first param. --- ** [tickets:#6941] Create activity events for commits** **Status:** closed **Labels:** activitystreams **Created:** Tue Dec 03, 2013 06:34 PM UTC by Tim Van Steenburgh **Last Updated:** Thu Dec 05, 2013 10:17 PM UTC **Owner:** Tim Van Steenburgh --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
