In the test, it'd be better if it was clear why the error handling would be invoked.
It'd be better to timing out rather than hanging, when something does goes wrong in the threads and isn't caught. There's quite a bit of logic overlap between hg & git's `last_commit_ids`: http://pastie.org/8547562 Could that be refactored and shared? Git's implementation specifies no_merges=True, we should be consistent with hg. `hg log` takes a `--no-merges` param; can we do this with `cmdutil.walkchangerevs` though? I prefer no merges, but showing merges on both would be ok too. It also seems that merge commits aren't displayed in log view (either via allura or commandline, which I don't really understand). Example: merge commit ada01d on /NEWS.txt in the SF 'coils' repo. Which makes it confusing when you see the merge commit on the tree view but not the history view. --- ** [tickets:#6821] Change hg browser to get "last commit" info from hg instead of mongo** **Status:** in-progress **Labels:** performance indexless **Created:** Thu Oct 31, 2013 06:27 PM UTC by Cory Johns **Last Updated:** Thu Dec 12, 2013 03:38 PM UTC **Owner:** Cory Johns [#6686] changed git to pull last commit info directly from the SCM instead of mongo, and SVN already did the same. Now we just need to change the Mercurial browser to do the same. --- Sent from sourceforge.net because allura-dev@incubator.apache.org is subscribed to https://sourceforge.net/p/allura/tickets/ To unsubscribe from further messages, a project admin can change settings at https://sourceforge.net/p/allura/admin/tickets/options. Or, if this is a mailing list, you can unsubscribe from the mailing list.
