On Fri, Dec 19, 2003 at 10:22:47AM +0100, Jaroslav Kysela wrote:
> > --- rme9652.c.ORIGINAL      Thu Dec 18 23:43:36 2003
> > +++ rme9652.c       Thu Dec 18 23:45:12 2003
> > @@ -1618,7 +1618,6 @@
> >  RME9652_SPDIF_RATE("IEC958 Sample Rate", 0),
> >  RME9652_ADAT_SYNC("ADAT1 Sync Check", 0, 0),
> >  RME9652_ADAT_SYNC("ADAT2 Sync Check", 0, 1),
> > -RME9652_ADAT_SYNC("ADAT3 Sync Check", 0, 2),
> >  RME9652_TC_VALID("Timecode Valid", 0),
> >  RME9652_PASSTHRU("Passthru", 0)
> >  };
> 
> Yes, duplicated controls ARE NOT ALLOWED NOW. Applied. Thanks.

Maybe snd_ctl_add() should print some debugging info (at least the control
name) when it encounters a duplicate control?  There were at least three
such bugs recently, and all of them required adding printk calls to the
driver to locate where it fails - this does not look like a good way...

Attachment: pgp00000.pgp
Description: PGP signature

Reply via email to