> Thanks! You patches are now applied to CVS. Thanks.
> I've added error check from tumbler_init(). Could you try out? You broke the build :) You added a '{' on one line accidently. Here's a patch. Other than that, your error checking code is fine. jack.
Index: tumbler.c =================================================================== RCS file: /cvsroot/alsa/alsa-driver/cards/ppc/tumbler.c,v retrieving revision 1.5 diff -u -r1.5 tumbler.c --- tumbler.c 2001/12/07 14:06:23 1.5 +++ tumbler.c 2001/12/07 18:54:19 @@ -453,7 +453,7 @@ if ((err = tumbler_init(chip)) < 0) return err; - if ((err = snd_pmac_keywest_find(chip, &mix->i2c, TAS_I2C_ADDR, tumbler_init_client)) < 0) { + if ((err = snd_pmac_keywest_find(chip, &mix->i2c, TAS_I2C_ADDR, +tumbler_init_client)) < 0) return err; /*