On 18 Feb 2002, Robert Love wrote:

> Manfred Spraul just pointed out to me that ALSA contains three lseek
> implementations, none of which use the new lseek locking rules.  While
> it is possible the ALSA people intended for there to be no locking (as
> in it not being needed), I suspect the recent change was overlooked.
>
> The lseek implementations are:
>
>       sound/core/hwdep.c :: snd_hwdep_llseek
>       sound/core/info.c :: snd_info_entry_llseek
>       sound/isa/gus/gus_mem_proc.c :: snd_gf1_mem_proc_llseek
>
> snd_hwdep_llseek in hwdep.c clearly does not need locking.  I suspect
> the other two functions do.  The BKL seems the only available option.
>
> Please apply.

Sorry to reply too late, but I've not received this email before. It seems
that LKML has some trouble. Only the part of patch for sound/core/info.c
is valid, because llseek in gus_mem_proc.c is called from snd_info_entry_llseek(),
thus the function is already protected.

                                                Jaroslav

-----
Jaroslav Kysela <[EMAIL PROTECTED]>
Linux Kernel Sound Maintainer
ALSA Project  http://www.alsa-project.org
SuSE Linux    http://www.suse.com


_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Reply via email to