At Tue, 10 Sep 2002 20:42:46 -0700 (PDT), Fernando Pablo Lopez-Lezcano wrote: > > [sent also to alsa-dev - maybe I missed an announcement about this?] > > The jack (Jack Audio Connection Kit, cvs from around the beginning of > September) code no longer compiles with the most recent alsa cvs: > > alsa_driver.c: In function `alsa_driver_set_parameters': > alsa_driver.c:403: too few arguments to function > `snd_pcm_hw_params_get_format' > alsa_driver.c:404: too few arguments to function > `snd_pcm_hw_params_get_access' > alsa_driver.c:416: too few arguments to function > `snd_pcm_hw_params_get_format' > alsa_driver.c:417: too few arguments to function > `snd_pcm_hw_params_get_access' > > There has been a backwards incompatible alsa api change. This is recent, I > guess, it compiles with cvs of 20020820.180035 (USA Pacific time). I know > there MUST a perfectly good reason for a backwards incompatible api change > at this point (some new extended format structure?), but may I say, > respectfully, something? > > ARGHHHHHHHHHH!!!!! > > :-)
ouch, i found that Jaroslav changed the functions above yesterday on cvs. the old one: int snd_pcm_hw_params_get_format(const snd_pcm_hw_params_t *params); the new one: int snd_pcm_hw_params_get_format(const snd_pcm_hw_params_t *params, snd_pcm_format_t *val); same are for subformat and access. i understand the reason why it was changed. the new one looks more consistent. but snd_pcm_format_t is enum, so it should be identical with int at any rate. (possibly c++ may complain about the difference between them, though.) i don't think it's a good idea to change such a basic api function at this time. the old one works fine, and we'll have never negative values for format, etc. this change will give more pain than gain. Jaroslav, could you consider to get them back to the old style? > When trying to run a jack server with a newly compiled alsa driver and > library I get a not very informative diagnostic from jack: > > jackd 0.37.2 > Copyright 2001-2002 Paul Davis and others. > jackd comes with ABSOLUTELY NO WARRANTY > This is free software, and you are welcome to redistribute it > under certain conditions; see the file COPYING for details > > creating alsa driver ... hw|1024|2|48000|swmon > programming error: unhandled format type > > It is not segfaulting (why? is it just chance that it did not?) marphy's law :) > To the alsa gurus: could a message be sent to alsa-dev when there are > backwards incompatible changes in the API please? It'd be good to know, I > think (at least _I_ would like to know). Please? usually such a change appears on alsa cvs annoucement, but this did't by unknown reason... Takashi ------------------------------------------------------- In remembrance www.osdn.com/911/ _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
