At Tue, 24 Sep 2002 10:44:58 -0700, David Shust wrote: > > >Takashi Iwai wrote > >the patch looks good except for the module options for spdif. > >since ac97_codec is a generic module, it's better to avoid > >such device specific options. isn't it detectable? > > If the Yamaha YMF753 spec provided a way to autodetect which pin was > being used for S/PDIF ouput, I'd use it.
ok. then user must choose. > The alternative to providing a module parameter via insmod would be > to provide a mixer control, where one would have the choice of > disabling S/PDIF output, or selecting pin 43 or 48. My instincts > told me that it made more sense having this as a module parameter, > as once one has determined which pin is being used, why would one > ever change that value. I felt the same about the parameter for > adding the delay after DAC startup in order to avoid missing > audio. I could make both items mixer controls if both Jaroslav and > Takashi feel it is better. Could you both please respond? the problem is, as mentioned in my last mail, ac97-codec is a generic module which is shared among drivers. for example, what happens if you have two cards with the ymf753? so, if this parameter is implemented as a module option, then it should go into the card module and store the value in ac97 struct, e.g. ac97->spec.ymf753.spdif_out_pin and spdif_delay. or, as you wrote above, implement this as a control switch. it's not too bad, because with this switch you can disable spdif output on the fly, too. Takashi ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
