Hi,

I can't dispute this section of Takashi's patch, except to note that
you probably don't want to clobber buf->size if the snd_xxx_fallback()
function sets it properly for you.

Chris


Index: alsa-driver/isa/sscape.c
===================================================================
RCS file: /cvsroot/alsa/alsa-driver/isa/sscape.c,v
retrieving revision 1.4
diff -u -u -r1.4 sscape.c
--- alsa-driver/isa/sscape.c    25 Sep 2002 11:48:08 -0000      1.4
+++ alsa-driver/isa/sscape.c    28 Sep 2002 20:22:27 -0000
@@ -161,15 +161,11 @@
 static struct dmabuf *get_dmabuf(struct dmabuf *buf, unsigned long s)
 {
        if (buf) {
-               while (((buf->data = snd_malloc_isa_pages(s, &buf->addr)) == NULL) && 
(s > PAGE_SIZE))
-                       s /= 2;
-
+               buf->data = snd_malloc_isa_pages_fallback(s, &buf->addr, &buf->size);
                if (!buf->data) {
                        printk(KERN_ERR "sscape: Failed to allocate %lu bytes for 
DMA\n", s);
                        return NULL;
                }
-
-               buf->size = s;
        }
 
        return buf;


-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Reply via email to