On Mon, 14 Oct 2002, Clemens Ladisch wrote:
> Jaroslav Kysela wrote:
> > On Mon, 14 Oct 2002, Clemens Ladisch wrote:
> >
> > > If the sequencer device for a card is requested unsuccessfully (e.g.
> > > "pmidi -l" when a USB MIDI device isn't yet connected), the device is
> > > plugged in, and then the device is accessed, ALSA doesn't load the
> > > sequencer driver.
> > >
> > > The reason for this is that snd_seq_client_use_ptr() assumes that the
> > > sequencer driver cannot be loaded when the card driver has failed to load
> > > before.
> > >
> > > This patch removes the "!card_requested" protection from the call to
> > > snd_seq_device_load_drivers().
> >
> > It's a bad idea. The better solution is to configure usbmgr to load usb
> > driver when hardware is plugged in.
>
> Loading usb (card) drivers (snd-usb-audio) works just fine, and the patch
> doesn't change the behaviour regarding card drivers. The problem is that
> the sequencer driver (snd-usb-midi) isn't loaded when the card driver has
> been loaded.
>
> > We definitely don't want to see thousands of failure messages in
> > /var/log/messages.
>
> snd_seq_device_load_drivers() has its own protection against multiple
> request_module() calls (the DRIVER_REQUESTED flag), so this isn't a
> problem.
I see. I think that this patch (in CVS) is better:
--- seq_clientmgr.c 13 Aug 2002 16:13:34 -0000 1.15
+++ seq_clientmgr.c 14 Oct 2002 16:20:10 -0000
@@ -152,9 +152,11 @@
}
} else if (clientid >= 64 && clientid < 128) {
int card = (clientid - 64) / 8;
- if (card < snd_ecards_limit && ! card_requested[card]) {
- card_requested[card] = 1;
- snd_request_card(card);
+ if (card < snd_ecards_limit) {
+ if (! card_requested[card]) {
+ card_requested[card] = 1;
+ snd_request_card(card);
+ }
snd_seq_device_load_drivers();
}
}
Jaroslav
-----
Jaroslav Kysela <[EMAIL PROTECTED]>
Linux Kernel Sound Maintainer
ALSA Project http://www.alsa-project.org
SuSE Linux http://www.suse.com
-------------------------------------------------------
This sf.net email is sponsored by:ThinkGeek
Welcome to geek heaven.
http://thinkgeek.com/sf
_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel
