On Wed, 23 Oct 2002, Jaroslav Kysela wrote:

> On Wed, 23 Oct 2002, Abramo Bagnara wrote:
> 
> > Jaroslav Kysela wrote:
> > > 
> > > Added ommited clear() functions
> > > 
> > > Index: pcm.c
> > >  /**
> > > + * \brief clear snd_pcm_hw_params_t structure
> > > + * \param obj pointer to structure
> > > + */
> > > +void snd_pcm_hw_params_clear(snd_pcm_hw_params_t *obj)
> > > +{
> > > +       assert(obj);
> > > +       memset(obj, 0, snd_pcm_hw_params_sizeof());
> > > +}
> > 
> > Why that _clear functions?
> > What's the expected semantic for "clear"?
> > 
> > When we designed new API I took in consideration them, but the lack of
> > usefulness and the ambiguity of semantic has pushed me to avoid them.
> 
> Well, you're right that the name is misleading, but wouldn't be good to 
> let to reuse a structure? Perhaps, _init suffix is better.

I got it. The initialization makes no sense for these structures.
I required this action for an internal function, but it should not be 
visible. Ok, I'll remove it. Thank you for the correction.

                                                Jaroslav

-----
Jaroslav Kysela <[EMAIL PROTECTED]>
Linux Kernel Sound Maintainer
ALSA Project  http://www.alsa-project.org
SuSE Linux    http://www.suse.com



-------------------------------------------------------
This sf.net email is sponsored by: Influence the future 
of Java(TM) technology. Join the Java Community 
Process(SM) (JCP(SM)) program now. 
http://ads.sourceforge.net/cgi-bin/redirect.pl?sunm0002en

_______________________________________________
Alsa-devel mailing list
[EMAIL PROTECTED]
https://lists.sourceforge.net/lists/listinfo/alsa-devel

Reply via email to