this one relies on the tascam-firmware downloader http://usb-midi-fw.sourceforge.net/tascam-firmware.tar.gz to be installed.
the following issues should have been improved. tell me, where I still miss :-) have fun, Karsten Am Dienstag 12 August 2003 18:38 schrieb Takashi Iwai: > while we're in here: i'm looking at the code now and have some > questions / suggestions to Karsten: > > * the comments in usbus428.c looks like the GPL/BSD dual license but > MODULE_LICENSE() is defined as GPL. is it correct? > > * what's the reason of the independent snd-usb-us428-dl module? > this module seems doing only feeding the firmware to the interface, > so why not in snd-usb-us428 itself? this will reduce the use of > inter_module_* stuffs which are obsolete in 2.6 kernels. > > * usbus428ctls.c defines mmap & co. they still be needed? > could they be replaced with the standard ALSA control API? > (btw, P_us428ctls_sharedmem_u may be unalighed to the page > when allocated via kmalloc(). so the mmap code looks buggy for > me anyway. also, please avoid virt_to_phys() as much as possible. > this is architecture dependent, and won't run on non-x86 well.) > > * 64bit division macros can be found in pcm.h. > the asm codes in usbus428audio.c can be removed. > > * there are still GCC-style of structs initialization in some parts :) > > * please follow the coding style described in linux/Documentation/ > CodingStyle. spaces after a (open) parenthesis are not common... > (i know it's a matter of tastes, but we should keep the consistent > style if possible.) > also, debug codes which are obviously unnecessary any more should be > removed in the release source codes. > > * you don't need to modify configure stuff but just add the following > to alsa-driver/utils/Modules.dep and run cvscompile again: > > %dir linux/sound/usb > snd-usb-us428-dl > |snd-usb-us428 snd-usb-audio snd-usb-us428-dl
alsa-driver-0.9.6+usbus428-008.diff.tar.bz2
Description: application/tbz
