Takashi Iwai wrote: >>>any chance to get the whole things into alsa tree? >> >>Takashi, >> >>I would love to get this into the ALSA tree. >>How do I go about doing this? >>Are there changes I need to make to the code to make it "acceptable"? > > > firstly, Jaroslav and I will review the patch. > the patch itself looks almost ok, if the indentation follows the > standard kernel style (see linux/Documentation/CondingStyle).
Getting asihpi.c into standard style should not be too much work. >>When you say the "whole thing", do you mean the ALSA part of our driver, or >>including our underlying HPI driver. > > i meant the latter, including HPI driver. > > since the HPI driver part is the essential part of the driver, we > surely need more review for that, too. Please, go ahead... tell me the worst - I won't be surprised. > IIRC, the HPI driver is GPL, so won't it be problem, right? No problem with using the code. However, it is extremely unlikely that we will redo all the HPI files to meet the CodingStandard. I have read it and it does say "preferred" not "mandatory". If its just a matter of running them all through "indent -kr -i8" then thats OK. > when the audioscience driver is promoted to the linux 2.6.0 kernel > tree, it must be anyway a complete set. then putting the whole stuffs > into alsa directory tree would be the easiest solution, i think. > > > Takashi Eliot Blennerhassett AudioScience Inc. -- Junk footer beyond this point. Read at your own risk. ------------------------------------------------------------- Sign up for ICQmail at http://www.icq.com/icqmail/signup.html ------------------------------------------------------- This sf.net email is sponsored by:ThinkGeek Welcome to geek heaven. http://thinkgeek.com/sf _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel
