At Mon, 12 Jan 2004 19:08:21 +0100, Wilfried Weissmann wrote: > > [1 <text/plain; us-ascii (7bit)>] > Takashi Iwai wrote: > > At Fri, 09 Jan 2004 23:04:49 -0400, > > Manuel Jander wrote: > > > >>Please apply to CVS. Thanks > >> > >>-----Forwarded Message----- > >>From: Wilfried Weissmann <[EMAIL PROTECTED]> > >>To: [EMAIL PROTECTED], [EMAIL PROTECTED] > >>Subject: via workaround error > >>Date: Fri, 09 Jan 2004 20:16:01 +0100 > >> > >>i made a stupid error when i wrote the via workaround patch. the pci > >>latency for the vortex was still set to 0xff when using autodetection > >>and no via chipset was found. i discovered this after i exchanged my > >>motherboard from a via kt133 to a sis 735. the fix is attached. the bug > >>should not have caused any troubles but it is just not right... > > > > > > i didn't receive the VIA workaround patch itself yet. > > could you send the whole patch? > > here we go...
thanks! > +static void __devinit snd_vortex_workaround(struct pci_dev *vortex, int fix) { > + struct pci_dev *via=NULL; > + /* autodetect if workarounds are required */ > + while( (via = pci_find_device(PCI_VENDOR_ID_VIA, > + PCI_DEVICE_ID_VIA_8365_1, via)) ) { > + if(fix == 255) { > + printk(KERN_INFO CARD_NAME > + ": detected VIA KT133/KM133. activating > workaround...\n"); > + fix = 3; // do latency and via bridge workaround > + } > + break; > + } i think "if" is enough in the above. > + > + int rc; gcc-2.9.x won't accept this. i applied the fixed version to cvs. please check it later. could you also provide the patch to INSTALL (document) file? thanks, Takashi ------------------------------------------------------- This SF.net email is sponsored by: Perforce Software. Perforce is the Fast Software Configuration Management System offering advanced branching capabilities and atomic changes on 50+ platforms. Free Eval! http://www.perforce.com/perforce/loadprog.html _______________________________________________ Alsa-devel mailing list [EMAIL PROTECTED] https://lists.sourceforge.net/lists/listinfo/alsa-devel