On Mon, Sep 28, 2009 at 14:11:51 -0400, Dustin J. Mitchell wrote: > +++ b/common-src/util.c > @@ -1282,3 +1282,15 @@ get_pcontext(void) > return pcontext; > } > > +#ifdef __OpenBSD__ [...] > diff --git a/common-src/util.h b/common-src/util.h > index 8604cf1..f74910a 100644 > --- a/common-src/util.h > +++ b/common-src/util.h > @@ -348,4 +348,14 @@ void proplist_add_to_argv(gpointer key_p, > gpointer user_data_p); > > > +/* Inform the OpenBSD pthread library about the high-numbered file > descriptors > + * that an amandad service inherits. This won't be necessary once the new > + * threading library is availble (OpenBSD 5.0?), but won't hurt anyway. See > the > + * thread "Backup issues with OpenBSD 4.5 machines" from September 2009. */ > +#ifdef __OpenBSD__ > +void openbsd_fd_inform(void); > +#else [...]
As you say, having this extra call shouldn't really hurt anything, but I
wondering if it would make sense to tweak the #ifdef so that is possible
to compile Amanda on OpenBSD without having to include the work-around
even in environments where it's not necessary (e.g. when using the new
theading library you mention)?
(For example, does Configure generate any particular #define related to
the use of the pthread library?)
Nathan
----------------------------------------------------------------------------
Nathan Stratton Treadway - [email protected] - Mid-Atlantic region
Ray Ontko & Co. - Software consulting services - http://www.ontko.com/
GPG Key: http://www.ontko.com/~nathanst/gpg_key.txt ID: 1023D/ECFB6239
Key fingerprint = 6AD8 485E 20B9 5C71 231C 0C32 15F3 ADCD ECFB 6239
signature.asc
Description: Digital signature
