On Mon, Sep 13, 2010 at 04:43:19PM -0500, Dustin J. Mitchell wrote: > I'm sorry, I gave the wrong patch before. The patch I intended hasn't > been committed yet, because I failed to correctly request review :) > > http://github.com/djmitche/amanda/commit/z11892 > > If anyone can review and confirm that patch, I'll get it committed.
In the above patch one single to double dash was missed (skipmissed) > > On Mon, Sep 13, 2010 at 3:27 PM, Jon LaBadie <[email protected]> wrote: > > More important, I found lots of other uninitialized errors with the > > various options. > Patched I still get uninitialized value errors. --num0: uninitialized value in pattern match (m//) at /usr/sbin/amoverview line 138. --togo0: uninitialized value in pattern match (m//) at /usr/sbin/amoverview line 153 --last: uninitialized value in string eq at /usr/sbin/amoverview line 122 > In general, amoverview needs some TLC. Orion's done a good job so > far, hopefully my patch above helps, and certainly others are welcome > to step up. > > I'm surprised that the long options with a single dash work at all, > but the "only need a unique prefix" thing is well-known. I'll get the > docs and usage fixed up to use double-dashes for long options. With your patch the long options still seem to work with a single dash. And another surprise, single letter options, or shortened versions of the options, work with single or double dash. Jon -- Jon H. LaBadie [email protected] JG Computing 12027 Creekbend Drive (703) 787-0884 Reston, VA 20194 (703) 787-0922 (fax)
