Chris,
Apply the attached patch, this bug is already fixed in 3.3.1
Jean-Louis
On 06/06/2012 11:13 AM, Chris Nighswonger wrote:
I woke up this morning to the following in my last evening's backup
report:
FAILURE DUMP SUMMARY:
taper: FATAL TypeError in method 'log_add', argument 2 of type 'char *'
A look a the log shows what appears to be an mtx error the taper or
changer does not know about. This appears to cause the taper to call
log_add with an integer or undef as the second arg which, in turn,
causes the taper to go south as we say.
I've attached the log for reference. I'm fairly sure this is a fringe
case, but the taper should still handle it gracefully imho.
Kind Regards,
Chris
diff --git a/perl/Amanda/Taper/Worker.pm b/perl/Amanda/Taper/Worker.pm
index c123b82..9c7683e 100644
--- a/perl/Amanda/Taper/Worker.pm
+++ b/perl/Amanda/Taper/Worker.pm
@@ -382,7 +382,7 @@ sub scribe_notif_new_tape {
# TODO: if $params{error} is set, report it back to the driver
# (this will be a change to the protocol)
- log_add($L_INFO, $params{'error'}) if defined $params{'error'};
+ log_add($L_INFO, "$params{'error'}") if defined $params{'error'};
if ($params{'volume_label'}) {
$self->{'label'} = $params{'volume_label'};
@@ -447,7 +447,7 @@ sub scribe_notif_log_info {
my $self = shift;
my %params = @_;
- log_add($L_INFO, $params{'message'});
+ log_add($L_INFO, "$params{'message'}");
}
##
