----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100088/#review303 -----------------------------------------------------------
Ship it! Looks Ok for me. But there should not be space between & or * and variable name. :) - Sergey On 2010-11-05 17:22:43, Stefan Derkits wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100088/ > ----------------------------------------------------------- > > (Updated 2010-11-05 17:22:43) > > > Review request for Amarok. > > > Summary > ------- > > -) Created new Class with some Helper Functions > -) Changed MetaQueryWidget to use the QStringList that contains all Filetypes > -) Meta::SqlTrack.type() now gets it's Information from the Database instead > of the FileExtension > > > Diffs > ----- > > shared/FileType.h 55c80b9 > shared/FileType.cpp PRE-CREATION > src/browsers/CollectionTreeItemModelBase.cpp 3f64a73 > src/core-impl/collections/support/MemoryFilter.cpp e2509ac > src/widgets/MetaQueryWidget.cpp 0249edf > tests/synchronization/CMakeLists.txt e5df2df > > Diff: http://git.reviewboard.kde.org/r/100088/diff > > > Testing > ------- > > Tested in the App, found no wrong Behaviour > > > Thanks, > > Stefan > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
