----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100156/#review353 -----------------------------------------------------------
Ship it! Haven't tried it but checked the diff. Seems to be simple and staight forward. - Ralf On 2010-11-17 08:44:38, Albert Farres wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100156/ > ----------------------------------------------------------- > > (Updated 2010-11-17 08:44:38) > > > Review request for Amarok. > > > Summary > ------- > > Compilations albums now are shown under Various Artists item on Ipod devices. > > > This addresses bug 207880. > https://bugs.kde.org/show_bug.cgi?id=207880 > > > Diffs > ----- > > src/core-impl/collections/ipodcollection/handler/IpodHandler.h 07e0380 > src/core-impl/collections/ipodcollection/handler/IpodHandler.cpp cd50661 > > src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.h > 44af297 > > src/core-impl/collections/ipodcollection/handler/capabilities/IpodReadCapability.cpp > 3825187 > > src/core-impl/collections/mediadevicecollection/handler/MediaDeviceHandler.cpp > d2c5248 > > src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.h > abf98a0 > > src/core-impl/collections/mediadevicecollection/handler/capabilities/ReadCapability.cpp > bbea5d0 > src/core-impl/collections/mtpcollection/handler/MtpHandler.h 095d3fa > src/core-impl/collections/mtpcollection/handler/MtpHandler.cpp f93eb99 > > src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.h > 598ede2 > > src/core-impl/collections/mtpcollection/handler/capabilities/MtpReadCapability.cpp > c95d43d > src/core-impl/collections/umscollection/handler/UmsHandler.h 70edc26 > src/core-impl/collections/umscollection/handler/UmsHandler.cpp c402c54 > > src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.h > 85f76d1 > > src/core-impl/collections/umscollection/handler/capabilities/UmsReadCapability.cpp > 071d19e > > Diff: http://git.reviewboard.kde.org/r/100156/diff > > > Testing > ------- > > Tested with one Ipod Classic (6th gen) > > > Thanks, > > Albert > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
