On Thu, Nov 18, 2010 at 2:51 PM, Sergey Ivanov <[email protected]> wrote: >> https://bugs.kde.org/show_bug.cgi?id=240811 >> The bug occurs because ProxyTrack::uidUrl() (ProxyCollectionMeta.cpp) returns >> a null QString, leading to a bad hash resolution in MoodbarManager, >> which then loads the >> same erroneous moodbar for all files. >> >> How do we implement uidUrl(). In the cases I can think of it makes >> sense to return >> the first track's uidUrl() or the "local" track's uidUrl() if available. >> >> The other workaround is that we use some other unique identifier in >> MoodbarManager, but >> uidUrl() is the most apt. >> > > What about this http://pastebin.com/4uR1rwbT ? It would be unique enough. > > --
I'm not too sure about this, since the moodbar plugin can have moodbars cached, and changing the uidUrl() means that the cache is invalidated. Also the MD5 makes it change all the time when tracks are added and removed, probably creating a lot of problems for Collection code which often relies on the uidUrl(). Nikhil _______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
