----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100191/ -----------------------------------------------------------
Review request for Amarok. Summary ------- Rewrite tag reading stuff to make It more OOP way. Add separat classes for each Tag format (ID3v2, APE, ASF, VorbisComment, MP4, MPC). Exclude almost all "magic words" (frame/field names) from code. TODO: Implement charset detection stuff. Complete ASF tags. Implement embedded covers support for MP4 files. Diffs ----- shared/FileType.h dc5e57b shared/FileType.cpp 63d81c7 shared/MetaTagLib.h ff27c92 shared/MetaTagLib.cpp f74df21 shared/TagsFromFileNameGuesser.h PRE-CREATION shared/TagsFromFileNameGuesser.cpp PRE-CREATION shared/tag_helpers/APETagHelper.h PRE-CREATION shared/tag_helpers/APETagHelper.cpp PRE-CREATION shared/tag_helpers/ASFTagHelper.h PRE-CREATION shared/tag_helpers/ASFTagHelper.cpp PRE-CREATION shared/tag_helpers/ID3v2TagHelper.h PRE-CREATION shared/tag_helpers/ID3v2TagHelper.cpp PRE-CREATION shared/tag_helpers/MP4TagHelper.h PRE-CREATION shared/tag_helpers/MP4TagHelper.cpp PRE-CREATION shared/tag_helpers/StringHelper.h PRE-CREATION shared/tag_helpers/StringHelper.cpp PRE-CREATION shared/tag_helpers/TagHelper.h PRE-CREATION shared/tag_helpers/TagHelper.cpp PRE-CREATION shared/tag_helpers/VorbisCommentTagHelper.h PRE-CREATION shared/tag_helpers/VorbisCommentTagHelper.cpp PRE-CREATION src/CMakeLists.txt 9ac230e src/musicbrainz/MusicBrainzFinder.cpp 78a07a6 utilities/collectionscanner/CMakeLists.txt 6be9319 Diff: http://git.reviewboard.kde.org/r/100191/diff Testing ------- Thanks, Sergey
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
