> On 2010-12-27 09:19:36, Sergey Ivanov wrote: > > src/MediaDeviceCache.cpp, line 89 > > <http://git.reviewboard.kde.org/r/100194/diff/1/?file=4918#file4918line89> > > > > & has greater priority then &&, parenthesis don't make difference. > > Stefan Derkits wrote: > Parenthesis make no difference for the compiler (and most probably also > no Speed Difference), but in cases where the Operator Precendence is not that > well known, they make the code easier to read --> I would leave them
I agree with Stefan. Better readability is a good thing. - Mark ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100194/#review621 ----------------------------------------------------------- On 2010-12-08 21:55:12, Lukáš Tinkl wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100194/ > ----------------------------------------------------------- > > (Updated 2010-12-08 21:55:12) > > > Review request for Amarok. > > > Summary > ------- > > This patch fixes identifying general USB storage mode media players, plus > adds some minor fixes and cleanups. The main change is in > UmsConnectionAssistant::identify method. > > > Diffs > ----- > > src/MediaDeviceCache.cpp babb8ff > > src/core-impl/collections/ipodcollection/support/IpodConnectionAssistant.cpp > 92339ff > src/core-impl/collections/umscollection/support/UmsConnectionAssistant.cpp > 5956a2b > > Diff: http://git.reviewboard.kde.org/r/100194/diff > > > Testing > ------- > > > Screenshots > ----------- > > Amarok in USB mode > http://git.reviewboard.kde.org/r/100194/s/21/ > > > Thanks, > > Lukáš > >
_______________________________________________ Amarok-devel mailing list Amarok-devel@kde.org https://mail.kde.org/mailman/listinfo/amarok-devel
