> On 2010-12-27 08:41:37, Sergey Ivanov wrote:
> > Looks good.

Then someone with push-access will need to push :D


- Philipp


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100244/#review619
-----------------------------------------------------------


On 2010-12-25 21:34:18, Philipp Schmidt wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100244/
> -----------------------------------------------------------
> 
> (Updated 2010-12-25 21:34:18)
> 
> 
> Review request for Amarok.
> 
> 
> Summary
> -------
> 
> Simply adding a switch to the setScheme() function to not parse the given 
> scheme but to simply set it in the according lineEdit when in advanced mode 
> and else do the parsing for the token widget fixes the problem.
> 
> 
> This addresses bug 255325.
>     https://bugs.kde.org/show_bug.cgi?id=255325
> 
> 
> Diffs
> -----
> 
>   ChangeLog 7343431 
>   src/dialogs/FilenameLayoutDialog.cpp 97b9253 
> 
> Diff: http://git.reviewboard.kde.org/r/100244/diff
> 
> 
> Testing
> -------
> 
> Preview is updated according to the selected preset, I also moved a set of 
> files successfully after changing the preset.
> 
> 
> Thanks,
> 
> Philipp
> 
>

_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel

Reply via email to