-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/100487/#review1141
-----------------------------------------------------------
There is a build error in your patch:
/home/bart/Code/amarok/src/core-impl/podcasts/sql/SqlPodcastProvider.cpp: In
member function ‘QFile*
Podcasts::SqlPodcastProvider::createTmpFile(Podcasts::SqlPodcastEpisodePtr)’:
/home/bart/Code/amarok/src/core-impl/podcasts/sql/SqlPodcastProvider.cpp:1334:
error: ‘class QString’ has no member named ‘toLocalFile’
I guess toLocalFile() is not required?
If you fix that it will probably be good.
- Bart
On Feb. 1, 2011, 3:26 a.m., Frank Steinmetzger wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/100487/
> -----------------------------------------------------------
>
> (Updated Feb. 1, 2011, 3:26 a.m.)
>
>
> Review request for Amarok.
>
>
> Summary
> -------
>
> See description and an example of the problem in the bug report. This quick
> and not very dirty fix makes Amarok use the MD5 of the download URL instead.
>
>
> This addresses bug 264813.
> https://bugs.kde.org/show_bug.cgi?id=264813
>
>
> Diffs
> -----
>
> src/core-impl/podcasts/sql/SqlPodcastProvider.cpp c814854
>
> Diff: http://git.reviewboard.kde.org/r/100487/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Frank
>
>
_______________________________________________
Amarok-devel mailing list
[email protected]
https://mail.kde.org/mailman/listinfo/amarok-devel
