> On May 15, 2011, 9:03 a.m., Ralf Engels wrote: > > The patch filtering out unknown Albums was > > "0ffe80bbd8fe074dea64abb985a413885a1ab765" > > > > Prune out any genres with empty names or the name "Unknown" when > > importing the Jamendo database. > > This gets rid of the "Unknown" genre at the top of the lsit that > > freezes Amarok when you try to expand it. > > Some albums might be filtered out by this, but a) these were not > > accessible anyway and b) if the album has not been tagged with even a > > single genre by the > > BUG: 213165 > > > > Can you test that your patch does not cause these problems to re-appear? > > Wolfgang Lorenz wrote: > This patch DOES cause the freeze to reappear, it was just uploaded as an > attachment to Bug 267065. Before reverting patch > "0ffe80bbd8fe074dea64abb985a413885a1ab765", the SQL queries should be > reworked to prevent these freezes.
Wolfgang, do you want to discard this request or do you want to rework it? - Ralf ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/100742/#review3327 ----------------------------------------------------------- On Feb. 25, 2011, 1:13 p.m., Wolfgang Lorenz wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/100742/ > ----------------------------------------------------------- > > (Updated Feb. 25, 2011, 1:13 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > The Amarok Jamendo-Plugin ignores albums, that come without a genre. As these > are rather many, this seems not advisable (see Bug 235184). > > This patch simply "unignores" albums without genre. The problem here is, it > makes Amarok freeze, when it comes to showing the contents of the "Unknown > genre"-Section, because the SQL query takes a very long time - more than an > hour on my computer (see Bug 267065). > > The second thing, this patch does is to write out the SQL-queries in debug > mode. > > Note: To search the database you still might need to apply patch > https://git.reviewboard.kde.org/r/100723/ (for Bug 233170) > Also Note: At the moment, this patch is really only for testing purposes. > > > This addresses bugs 235184 and 267065. > https://bugs.kde.org/show_bug.cgi?id=235184 > https://bugs.kde.org/show_bug.cgi?id=267065 > > > Diffs > ----- > > src/services/ServiceSqlQueryMaker.cpp 2cb1242 > src/services/jamendo/JamendoXmlParser.cpp b8735e8 > > Diff: http://git.reviewboard.kde.org/r/100742/diff > > > Testing > ------- > > > Thanks, > > Wolfgang > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
