----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/101798/#review4253 -----------------------------------------------------------
Ship it! Looks very good and is working on my own firefly server. When you commit it you might want to remove some debug. Can you commit or should I? - Bart On June 28, 2011, 9:19 p.m., Lukas Sandström wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/101798/ > ----------------------------------------------------------- > > (Updated June 28, 2011, 9:19 p.m.) > > > Review request for Amarok. > > > Summary > ------- > > Make Amarok get the DAAP response types from the server instead of hardcoding > them. This should improve the robustness of the DAAP protocol handling > somewhat. > > > Diffs > ----- > > src/core-impl/collections/daap/daapreader/Reader.h > 882d6d2fd58fb46fe6db4f224084a6e6b5fb8be6 > src/core-impl/collections/daap/daapreader/Reader.cpp > 5501693656a23f63cd35b55c8f9d4e2263b86e5c > > Diff: http://git.reviewboard.kde.org/r/101798/diff > > > Testing > ------- > > I'm using it at home with Firefly. > > > Thanks, > > Lukas > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
