----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102055/ -----------------------------------------------------------
(Updated Aug. 3, 2011, 9:20 p.m.) Review request for Amarok and Ralf Engels. Changes ------- also changed VorbisCommentHelper Summary ------- Rewrite if else else if Constructs to switch statements Add common Frame Names to m_fieldMap Diffs (updated) ----- shared/tag_helpers/ID3v2TagHelper.cpp 27e0cf0a9f6dc0bfbbd54cab65cb65dd6bef8a33 shared/tag_helpers/TagHelper.h f8e7fd9fdad0ac3abd6efd34ad5e00c973233a6d shared/tag_helpers/TagHelper.cpp 96f763e0839b59194484c1aa94cd266d88ad5add shared/tag_helpers/VorbisCommentTagHelper.cpp 1222f9fc9e0b3f04499d9542e29e58b12d8c5f1b Diff: http://git.reviewboard.kde.org/r/102055/diff Testing ------- compared output of collectionscanner before & after patch -> fixed some, but still some slight problems with TrackNo Thanks, Stefan
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
