----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/102600/#review6491 -----------------------------------------------------------
Just had a quick look at it, 2 small things first: -) you do some debug output in PlaylistBrowser.. (one of the first files), this is maybe a relic from development, think about if it is needed in master and if yes then try to make it a better debug output -) every file where you did a substantial change, you should write your name in the copyright header - Stefan On Sept. 13, 2011, 10:44 p.m., Lucas Gomes wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/102600/ > ----------------------------------------------------------- > > (Updated Sept. 13, 2011, 10:44 p.m.) > > > Review request for Amarok, Stefan Derkits and Bart Cerneels. > > > Summary > ------- > > The attached diff is the work done during this summer to integrate > gpodder.net web service with Amarok. > > Added features: > > Podcast subscription synchronisation. > Podcast status synchronisation. > Browse through podcasts suggested by gpodder.net. > Browse through gpodder.net top recommended podcasts. > > > Diffs > ----- > > src/CMakeLists.txt 962070d3b50089a29fee7d9a3154639602a3332a > src/browsers/playlistbrowser/PlaylistBrowserModel.h > 76ccb10313e0c1451c2531c82957790cd963da8e > src/browsers/playlistbrowser/PlaylistBrowserModel.cpp > ff18d83c4fde71f27afa357d7bfe9883f31d0032 > src/browsers/playlistbrowser/PodcastModel.h > ce1a86ffb92f8833896c28dfe9988532a2b78437 > src/browsers/playlistbrowser/PodcastModel.cpp > 4aad518713356e97fd69abe0ca0962df8bb23eef > src/browsers/playlistbrowser/QtGroupingProxy.cpp > e0b4e7a1e7616e8708b0fe5eddf9aa9039f2b413 > src/core-impl/playlists/types/file/PlaylistFileSupport.cpp > 2dcc0cdd9c706e3840e5a38b9cfec0c1c1d0c3ac > src/core-impl/playlists/types/file/m3u/M3UPlaylist.cpp > c64cb976553348a824d0107520492c8ecf779287 > src/core-impl/playlists/types/file/xspf/XSPFPlaylist.cpp > 0a3c99aa1034a73109e75ce447b8b9177f1670e8 > src/core-impl/podcasts/gpodder/GpodderPodcastMeta.h PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderPodcastMeta.cpp PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderProvider.h PRE-CREATION > src/core-impl/podcasts/gpodder/GpodderProvider.cpp PRE-CREATION > src/core-impl/podcasts/sql/SqlPodcastMeta.h > 011091158b7d5fbb215e87b6c5c76dd96a5faa98 > src/core-impl/podcasts/sql/SqlPodcastMeta.cpp > e88bc9e345ba39bc4f92f5ff4adbc0b4795f9893 > src/core-impl/podcasts/sql/SqlPodcastProvider.cpp > 83e9b99291b880ba3ec2466fb40c28812e6b3a39 > src/core/playlists/Playlist.h f88b07043056e7990f5ade76bc58e8dccc837caf > src/core/podcasts/PodcastMeta.h 21364b410ff0fdc9524a2d521538e361b40de209 > src/core/podcasts/PodcastMeta.cpp fb82fa87778028aeb68ab2e64ec5964482b21009 > src/main.cpp 7306e84a7c31f402b52edca901f7430999acbc27 > src/playlistmanager/PlaylistManager.h > 54d63b1a4b0330d91c8eb088e1ff4105a62bf9e1 > src/playlistmanager/PlaylistManager.cpp > 333ff17daad3c99bd81f70d206c0299b54115fce > src/playlistmanager/SyncRelationStorage.h > 2a2681da85b608558834d66c73c115fda0aa4eed > src/playlistmanager/SyncRelationStorage.cpp > b151243fc10f787113cb0792083d4d723c3a49ba > src/playlistmanager/SyncedPlaylist.h > 54914c751dc5253bd51ca2ce1af6b64061994068 > src/playlistmanager/SyncedPlaylist.cpp > c8383b5b08e11ffff25310ddeebe714869a0c3d3 > src/playlistmanager/SyncedPodcast.h PRE-CREATION > src/playlistmanager/SyncedPodcast.cpp PRE-CREATION > src/playlistmanager/file/KConfigSyncRelStore.h > 4674f660532e782299f433888743624c551c98b6 > src/playlistmanager/file/KConfigSyncRelStore.cpp > a8575935302fc396c75ab452ec9d7787f8a20422 > src/playlistmanager/file/PlaylistFileProvider.cpp > 728030d4c73656cb3354db2b03df2cbba1129b9c > src/playlistmanager/sql/SqlPlaylist.cpp > b2a9ca52589882a4877b687abd6dd04967237db0 > src/services/gpodder/CMakeLists.txt > 97f14b33c1728165e15d5f524a3e102896775cdf > src/services/gpodder/GpodderConfigWidget.ui PRE-CREATION > src/services/gpodder/GpodderService.h > fac508a8b0d5af293ae3529025690b8b740c7550 > src/services/gpodder/GpodderService.cpp > e0cb02f33c6be9ae2aa2cf5939e40e9689fac027 > src/services/gpodder/GpodderServiceConfig.h PRE-CREATION > src/services/gpodder/GpodderServiceConfig.cpp PRE-CREATION > src/services/gpodder/GpodderServiceModel.h > 1fbc90d637078754aa91a932e46a46b869b97c33 > src/services/gpodder/GpodderServiceModel.cpp > d899456b530752199012e5441a36b0ada643b793 > src/services/gpodder/GpodderServiceSettings.h PRE-CREATION > src/services/gpodder/GpodderServiceSettings.cpp PRE-CREATION > src/services/gpodder/GpodderTreeItem.h > 5698d5bf64456947e8e86efb1e3b7a089515e423 > src/services/gpodder/GpodderTreeItem.cpp > bfa216e58439af6c6961396143cdb5d10e8d7684 > src/services/gpodder/amarok_service_gpodder_config.desktop PRE-CREATION > > Diff: http://git.reviewboard.kde.org/r/102600/diff > > > Testing > ------- > > This patch is the result of git diff for the range of several commits prior > to HEAD, rebased on current master, and should build. Everything is working > as expected and there aren't any known issues. > > > Thanks, > > Lucas > >
_______________________________________________ Amarok-devel mailing list [email protected] https://mail.kde.org/mailman/listinfo/amarok-devel
